Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce typo in ICorDebug public API names #76966

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Reintroduce typo in ICorDebug public API names #76966

merged 1 commit into from
Oct 13, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 12, 2022

Fixes #76960

@ghost ghost assigned jkotas Oct 12, 2022
@ghost
Copy link

ghost commented Oct 12, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76960

Author: jkotas
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Oct 12, 2022

/backport to release/7.0

@jkotas jkotas requested a review from tommcdon October 12, 2022 20:31
@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3237700119

@jkotas jkotas requested a review from noahfalk October 12, 2022 20:31
@jkotas
Copy link
Member Author

jkotas commented Oct 12, 2022

cc @am11

@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Merged
am11
am11 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn’t realized that it is public. Thanks! :)

@teo-tsirpanis
Copy link
Contributor

teo-tsirpanis commented Oct 12, 2022 •
edited
Loading

Why reintroduce the typo? It is only a source, not a binary breaking change, and has been done before in #60999 (though I can see the argument that maybe this typo has existed for longer).

Answered in #76960 (comment).

@build-analysis build-analysis bot mentioned this pull request Oct 13, 2022
Closed
2 tasks
@jkotas jkotas merged commit e216458 into dotnet:main Oct 13, 2022
@jkotas jkotas deleted the reintroduce-typo branch October 13, 2022 06:03
@vargaz
Copy link
Contributor

vargaz commented Oct 13, 2022

This seems to have broken the mono build, CI didn't run the mono lanes on this PR:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=50983&view=logs&j=d3cc09f4-7598-5083-c32b-3d75aa946de0&t=69808874-331d-5f38-5702-6a7cd5ef963b&l=2334

@akoeplinger
Copy link
Member

akoeplinger commented Oct 13, 2022 •
edited
Loading

This is another case where the missing mscordbi trigger path is causing mono build breaks (see #76832 (comment)), we need to add these paths to the trigger.

@janvorli janvorli mentioned this pull request Oct 13, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@tommcdon tommcdon tommcdon approved these changes

@am11 am11 am11 approved these changes

@stephentoub stephentoub stephentoub approved these changes

@noahfalk noahfalk Awaiting requested review from noahfalk

Assignees

@jkotas jkotas

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoreCLR 7.0 have changed public Debug API. Why?
8 participants
@jkotas @teo-tsirpanis @vargaz @akoeplinger @stephentoub @am11 @tommcdon @hoyosjs