[release/7.0] Reintroduce typo in ICorDebug public API names #76967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #76966 to release/7.0 /cc @jkotas Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@mmitche do we still have runway to include this in GA? |
|
Approved by Tactics via email. |
stephentoub
approved these changes
Oct 12, 2022
hoyosjs
approved these changes
Oct 12, 2022
noahfalk
approved these changes
Oct 12, 2022
|
Yes |
|
Cool, thanks. Will merge after checking the CI. |
|
Re-running the failed CI leg. There were network issues. |
Fixes build break
|
The CI re-run had one failure, but unrelated and I've seen it before: #76906 Approved by Tactics and signed off by lots of folks. Merging now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76966 to release/7.0
/cc @jkotas
Customer Impact
Build break after updating to .NET 7 ICorDebug header files. The build break was introduced by attempt to fix a typo in publicly documented API name. The typo fix is being reverted by this change.
Testing
Standard CI testing, verified that the API name matches the documented name.
Risk
Low
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.