-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Reduce CoreCLR PAL"" #76972
Conversation
@am11 this would not work. The PAL maintains its own copy of the environment, so the |
@jkotas the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ff18024
to
647cc64
Compare
@janvorli, Mono's llvmaot leg is failing with:
Looks like dummy change was needed in src/tests as well. |
@am11 this doesn't seem to be related to my changes. I have not removed anything that could result in this error. And yesterday I've built using the same command line that the failing build is using locally and it passed. |
You are right, it is caused by #76966. |
Ugh. #77002 |
Reverts #76860