[Automated] Merge 'master' into 'future' #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transactions Fixes #3967 Update RoslynVisualStudioWorkspace.OpenInvisibleEditor to remove the assumption that Solution.GetDocument(DocumentId) will always work for a given IVisualStudioHostDocument's ID. GetDocument returns null on all AdditionalDocuments, causing the eventual reported NullReferenceException.
Affected operations including: - Delete (and TypeChar) - Backspace - Return - Cut - Paste
Here's the new behavior for all deletion without selected text related operations: - if caret is in editable area, no change in behavior. - if caret is in active prompt area, move caret to the closest location first. - if caret is in other readonly area, do nothing. Here's the new behavior for all deletion with selected text related operations: - if the selection overlaps with editable area, caret will be moved to a position in editable area that is closest to it's original position. - Otherwise, do nothing (and preserve the selection). Deletion related operations including: - Delete (and TypeChar) - Backspace - Return and BreakLine - Paste - Cut
…ffects of "Debug" in the diffs
Avoid repeatedly calling ISyntaxFactsService.IsInInactiveRegion, which calls SyntaxTree.GetToken. GetToken needs to traverse directive trivia to find the token it is attached to. This results in n ^ 2 traversals of the tree if there are repeated directive before the line to indent. Additionally, when the indenter determines that it's examining a line inside a disabled region, instead of examining the previous line, it examines the first line preceeding the current line that isn't inside a disabled region. Fixes #5394.
Conflicts: src/EditorFeatures/CSharpTest/Diagnostics/Async/AddAwaitTests.cs src/Features/CSharp/Portable/CodeFixes/Async/CSharpAddAwaitCodeFixProvider.cs src/Features/VisualBasic/Portable/CodeFixes/Async/VisualBasicAddAwaitCodeFixProvider.vb
Some of the references were outdated and some of the NuGet packages were incorrectly authored. With the new references we don't need to do any extra work to copy over the CoreCLR runtime -- it's copied as a reference by NuGet 3 without any extra work.
Update to a new version of the Roslyn Diagnostics analyzer package.
Remove unnecessary references that we causing warnings on Mono
Missed commits from FixInsertAwait
… suppressions commands in ServicesVisualStudio - these commands have been moved down to the core CodeAnalysis layer.
New version of analyzers
All assignments in an expression tree should be an error. Self assignment was being flagged as only a warning which lead to later errors in code generation. Changed the behavior to warn and error for self assignment (matches native compiler behavior). close #3826
Add support for un-suppressing diagnostics from error list
Self assignment in expression trees should error
Fix function pointer representation
Make InteractiveWindow use HACK_ThemeColorFixer
Add regression tests for interactive using bugs
Add a separate package for the Linux coreclr runtime
Reduce VBCSCompiler polling frequency to 1Hz
Add null checks for #load'ed trees...
Minor code cleanup
Allow #r package reference without explicit version
tannergooding
added a commit
that referenced
this pull request
Sep 28, 2015
[Automated] Merge 'master' into 'future'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.