Make InteractiveWindow use HACK_ThemeColorFixer #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue 4930 dotnet#4930
| @@ -52,6 +52,8 @@ protected override void Initialize() | |||
|
|
|||
| _componentModel = (IComponentModel)GetService(typeof(SComponentModel)); | |||
| _interactiveWindowProvider = _componentModel.DefaultExportProvider.GetExportedValue<TVsInteractiveWindowProvider>(); | |||
| KnownUIContexts.ShellInitializedContext.WhenActivated(() => | |||
| _componentModel.GetService<HACK_ThemeColorFixer>()); | |||
There was a problem hiding this comment.
@genlu does this change only affect the pop ups?
There was a problem hiding this comment.
@ManishJayaswal based on the code of HACK_ThemeColorFixer, it affects both tooltip and immediate , although I don't know what an immediate is...
There was a problem hiding this comment.
The "immediate" IClassificationFormatMap that we're updating is for the Immediate Window (eventually mapping down to DefGuidList.guidImmediateWindowFontCategory.
|
@dotnet-bot retest this, please |
|
👍, assuming you manually verified that it works. |
|
👍 |
genlu
added a commit
that referenced
this pull request
Sep 25, 2015
Make InteractiveWindow use HACK_ThemeColorFixer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #4930
@amcasey @dpoeschl @tmat @cston @KevinH-MS @ManishJayaswal