Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests for interactive using bugs #5451

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Add regression tests for interactive using bugs #5451

merged 1 commit into from
Sep 25, 2015

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Sep 25, 2015

@amcasey
Copy link
Member Author

amcasey commented Sep 25, 2015

After two days of fixing (distinct!) stack overflows, I've concluded that the approach I was taking was fundamentally flawed. These tests capture the things I learned along the way. I hope that part of my product change might be salvageable (esp for global and #load usings), but I'm going to switch gears for a bit.

@amcasey
Copy link
Member Author

amcasey commented Sep 25, 2015

FYI @cston @tmat @KevinH-MS @ManishJayaswal

amcasey added a commit that referenced this pull request Sep 25, 2015
@amcasey
Merge pull request #5451 from amcasey/UsingTests
8590192 
Add regression tests for interactive using bugs
@amcasey amcasey merged commit 8590192 into dotnet:master Sep 25, 2015
@amcasey amcasey deleted the UsingTests branch September 25, 2015 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Interactive cla-already-signed Interactive-ScriptingLogic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcasey @dnfclas