Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of additional package feeds set by default #1561

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Removal of additional package feeds set by default #1561

merged 2 commits into from
Apr 23, 2019

Conversation

johnbeisner
Copy link

@johnbeisner johnbeisner commented Apr 17, 2019 •
edited
Loading

Removal of additional package feeds set by default

@johnbeisner johnbeisner added this to the 3.0.1xx milestone Apr 17, 2019
@johnbeisner johnbeisner requested review from nguerrera, dsplaisted and a team April 17, 2019 20:10
@johnbeisner johnbeisner self-assigned this Apr 17, 2019
dsplaisted
dsplaisted approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are CI failures with a test that will need to enable these feeds.

@johnbeisner johnbeisner changed the title Removal of additional package feeds set by default [WIP] Removal of additional package feeds set by default Apr 17, 2019
@nguerrera
Copy link

Do not merge until Tuesday. Decision was made to hold this change until preview 6. We need an update to the README.md with prominent instructions to add feeds for daily builds.

@johnbeisner johnbeisner changed the title [WIP] Removal of additional package feeds set by default Removal of additional package feeds set by default Apr 23, 2019
@johnbeisner johnbeisner merged commit ca9216c into dotnet:master Apr 23, 2019
@johnbeisner johnbeisner mentioned this pull request Apr 23, 2019
Merged
@johnbeisner johnbeisner deleted the RemoveDotnetFeedBundledVersions branch April 23, 2019 21:59
@weshaggard weshaggard mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@nguerrera nguerrera Awaiting requested review from nguerrera

Assignees

@johnbeisner johnbeisner

Labels
None yet
Projects
None yet
Milestone
3.0.1xx
Development

Successfully merging this pull request may close these issues.
3 participants
@johnbeisner @nguerrera @dsplaisted