Update Track 2 packages to NuGet latest versions #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
requested review from
chidozieononiwu,
danieljurek and
mitchdenny
as code owners
tg-msft
approved these changes
Jul 17, 2019
jsquire
approved these changes
Jul 17, 2019
weshaggard
reviewed
Jul 17, 2019
| @@ -30,6 +30,8 @@ | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <IncludeSymbols>true</IncludeSymbols> | |||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | |||
| <!-- Avoid implicitly added preview feeds --> | |||
| <AddDotnetfeedProjectSource>false</AddDotnetfeedProjectSource> | |||
There was a problem hiding this comment.
Looks like this won't be necessary after we move to preview 6, dotnet/installer#1561. However I'm good with this for now. Unless there is a strong reason I don't plan to move the toolset version until .NET Core 3 ships stable.
weshaggard
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview SDK was bringing implicit NuGet sources that worked on some machines (including CI) but not the others allowing non-Nuget package versions to slip through.