Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the ReadME #1715

Merged
merged 5 commits into from
Apr 23, 2019
Merged

Update to the ReadME #1715

merged 5 commits into from
Apr 23, 2019

Conversation

johnbeisner
Copy link

@johnbeisner johnbeisner requested review from dsplaisted and a team April 23, 2019 19:20
@johnbeisner johnbeisner self-assigned this Apr 23, 2019
dsplaisted
dsplaisted reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my suggestions we discussed:

  • Move the addition to the "Note" section right above the table, also un-"quote" it to avoid de-emphasizing it
  • Remove feeds from table
  • Remove references to coherence

dsplaisted
dsplaisted approved these changes Apr 23, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@dsplaisted @johnbeisner
Update README.md
fe1ddd2 
Co-Authored-By: johnbeisner <[email protected]>
@johnbeisner johnbeisner merged commit 510c6ee into dotnet:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

Assignees

@johnbeisner johnbeisner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnbeisner @dsplaisted