ApiCompat no longer passes IntermediateOutputPath

[sbomer]

• This issue is blocking arcade update in mono/linker
• This issue is causing unreasonable pain

An arcade update in mono/linker is failing on ApiCompat.

It looks like ApiCompat was changed to no longer pass IntermediateOutputPath: d6dd7a0#diff-3c3f2c92eeec9b69dac2deccfac46603L72, so it isn't resolving the implementation assembly.

@dougbu is this expected? If so, what's the supported way to tell ApiCompat where to find the IntermediateAssembly?

[dougbu]

Yes, this is expected. We were not aware of scenarios in which $(IntermediateOutputPath) mattered. What is the case @ericstj and I missed?

/fyi the previous conversation starts with #4585 (comment)

[sbomer]

The scenario is an implementation csproj that has a ProjectReference to its contract project (with ReferenceOutputAssembly false) for comparison. In this case ReferencePath doesn't contain the intermediate assembly.

Thanks for the pointer - I gave the discussion a read, but don't think I have all the context necessary to understand the details. I'm happy to change how we invoke it - that was just how I saw others (dotnet/runtime IIRC) doing it at the time.

[dougbu]

@ericstj how do you prefer we handle this?

[ericstj]

@dougbu my suggestions was based on --contract-depends, not --impl-dirs. In the case of --contract-depends IntermediateOutputPath is not needed since the actual contract is passed in. In the case of --impl-dirs it is required. I think you should undo your change to --impl-dirs

[dougbu]

@ericstj I'm fine reverting that change, restoring $(IntermediateOutputPath) in the forward comparison's --impl-dirs. However, that option is exactly the same as --contract-depends in the reversed comparison. I'll fix things up in both (tomorrow).

[dougbu]

Opened #5373.

@sbomer do you have a way to test this out locally before we get this in and so on? For example, changing files in your packages folder with the two-word update should work.

[sbomer]

@dougbu thanks! Yes, I've confirmed that the fix works locally. I also confirmed that just the ApiCompatArgs part of the fix is enough for our scenario.