Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore use of $(IntermediateOutputPath) in ApiCompat commands #5373

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Restore use of $(IntermediateOutputPath) in ApiCompat commands #5373

merged 2 commits into from
Apr 29, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Apr 29, 2020

@dougbu
Restore use of $(IntermediateOutputPath) in ApiCompat commands
e6e3669 
- #5361
- pass property value in `--impl-dirs` argument in `ValidateApiCompatForSrc` target
- pass property value in `----contract-depends` argument in `RunMatchingRefApiCompat` target
- reverts small part of #4585
  - specifically, 24d6981
@dougbu dougbu requested review from sbomer and ericstj April 29, 2020 01:22
@dougbu dougbu mentioned this pull request Apr 29, 2020
Open
2 tasks
sbomer
sbomer approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the ApiCompatArgs change fixes the issue we were hitting. Thanks!

@dougbu
Update src/Microsoft.DotNet.ApiCompat/build/Microsoft.DotNet.ApiCompa…
507766f 
…t.targets


- revert change in `RunMatchingRefApiCompat` target
@dougbu
Copy link
Member Author

dougbu commented Apr 29, 2020

I think we're done now. Agreed @ericstj❔

@dougbu dougbu merged commit 62fc25d into master Apr 29, 2020
@dougbu dougbu deleted the dougbu/intermediate.5361 branch April 29, 2020 23:13
@dougbu
Copy link
Member Author

dougbu commented Apr 29, 2020

@missymessa, @riarenas if I remember correctly, this should be in the '.NET Eng - Latest' channel tonight or tomorrow. Which is likely?

@missymessa
Copy link
Member

@dougbu if you just merged this, then likely Friday.

@dougbu
Copy link
Member Author

dougbu commented Apr 29, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

@sbomer sbomer sbomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @missymessa @sbomer @ericstj