Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update dependencies from dotnet/arcade #1144

Merged
merged 4 commits into from
Apr 27, 2020
Merged

[master] Update dependencies from dotnet/arcade #1144

merged 4 commits into from
Apr 27, 2020

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 1e7883c0-a076-4718-e822-08d6be00caf8
  • Build: 20200421.14
  • Date Produced: 4/21/2020 10:41 PM
  • Commit: e13ae00db986456a5012f2d9d479d893b3f5aff6
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.ApiCompat: from 5.0.0-beta.20201.2 to 5.0.0-beta.20221.14
    • Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20201.2 to 5.0.0-beta.20221.14

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
61a3580 
…421.14

- Microsoft.DotNet.ApiCompat: 5.0.0-beta.20201.2 -> 5.0.0-beta.20221.14
- Microsoft.DotNet.Arcade.Sdk: 5.0.0-beta.20201.2 -> 5.0.0-beta.20221.14
@dotnet-maestro dotnet-maestro bot requested a review from marek-safar as a code owner April 27, 2020 12:00
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 27, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: linker-ci (Build macOS), linker-ci (Build Linux), linker-ci (Build Windows_NT)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@akoeplinger
Copy link
Member

Looks like the new ApiCompat detects some issues:

TypesMustExist : Type 'Mono.Linker.AnnotationStore' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.AssemblyAction' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.LinkContext' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.MessageCategory' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.MessageContainer' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.MessageOrigin' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.MethodAction' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.OverrideInformation' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.TypePreserve' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.Steps.BaseStep' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.Steps.BaseSubStep' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.Steps.IStep' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.Steps.ISubStep' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.Steps.SubStepsDispatcher' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
TypesMustExist : Type 'Mono.Linker.Steps.SubStepTargets' does not exist in the implementation but it does exist in the contract. [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]
ApiCompat failed for '/home/vsts/work/1/s/artifacts/bin/Mono.Linker/Release/netcoreapp3.0/illink.dll' [/home/vsts/work/1/s/src/linker/Mono.Linker.csproj]

@marek-safar

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 27, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: linker-ci, linker-ci (Build macOS), linker-ci (Build Linux), linker-ci (Build Windows_NT)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@marek-safar
Copy link
Contributor

It looks like the new version of the tool is doing something different (the APIs are there).

@sbomer could you please have a look

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 27, 2020 •
edited
Loading

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: linker-ci, linker-ci (Build Linux_Mono), linker-ci (Build macOS), linker-ci (Build Lint), linker-ci (Build Linux), linker-ci (Build Windows_NT)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@sbomer sbomer mentioned this pull request Apr 27, 2020
Open
2 tasks
@dotnet-maestro dotnet-maestro bot merged commit 4d6d8ad into master Apr 27, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-d0bea239-ae2a-466e-957f-6c420dc3abf5 branch April 27, 2020 22:20
tkapin pushed a commit to tkapin/runtime that referenced this pull request Jan 31, 2023
@dotnet-maestro
[master] Update dependencies from dotnet/arcade (dotnet/linker#1144)
ee5faeb 
* Update dependencies from https://github.com/dotnet/arcade build 20200421.14

- Microsoft.DotNet.ApiCompat: 5.0.0-beta.20201.2 -> 5.0.0-beta.20221.14
- Microsoft.DotNet.Arcade.Sdk: 5.0.0-beta.20201.2 -> 5.0.0-beta.20221.14

* Add dotnet-tools nuget feed

* Work around ApiCompat change

dotnet/arcade#5361

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Sven Boemer <[email protected]>

Commit migrated from dotnet/linker@4d6d8ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akoeplinger @marek-safar @sbomer