Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test automation #13

Closed
wants to merge 48 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
498efdc
Add composite index for data migration (#13057)
marquestye Apr 19, 2024
81eae17
[#13060] Add beta 5 liquibase changelog and developers json (#13061)
ziqing26 Apr 19, 2024
0a0e7c9
[#12048] Update changelog docs and changelog name (#13062)
NicolasCwy Apr 20, 2024
10e96cb
[#12048] Migrate StudentCourseDetailsPageE2ETest (#13012)
cedricongjh Apr 20, 2024
76db4cc
[#11878] Account Request Indexing Script (#13076)
domoberzin Apr 22, 2024
6b83e4f
[#11878] Add CAPTCHA to ARF (#13081)
xenosf Apr 23, 2024
e738e25
[#13064] Use AccountRequestUpdateRequest as parameter (#13068)
Stain19 Apr 24, 2024
a2a9ef3
[#12048] Migrate FeedbackRubricQuestionsE2E (#13078)
yuanxi1 Apr 28, 2024
34248a0
[#12048] Migrate SubmitFeedbackResponseAction tests (#13033)
FergusMok May 2, 2024
1ea04f4
[#12900] Gradle task componentTests should not stop entirely when onl…
emrekenar May 12, 2024
06bfafd
[#12048] Remove null default section (#13040)
FergusMok May 12, 2024
7b75dad
[#13126] Fix failing component test cases (#13127)
dishenggg Jun 11, 2024
5ed1cf7
[#13126] Update timezone db (#13128)
wkurniawan07 Jun 11, 2024
ec1f276
[#13109] IndexOutOfBoundsException encountered by LogsProcessor (#13120)
Ashwinn11 Jun 12, 2024
6114677
[#13103] Account request form: No need to CC the email 'Acknowledgeme…
Ashwinn11 Jun 12, 2024
40350ef
Remove duplicate call to loadfeedbacksessionsforcourse (#13130)
Respirayson Jun 22, 2024
efeffd4
[#13102] Admin rejecting account request: give actual account in the …
Andy-W-Developer Jun 28, 2024
015b872
[#12901] Check if the search service is active in account request sea…
cliu585 Jun 28, 2024
b402863
[#13105] Admin managing account requests: use spinners to indicate ac…
Respirayson Jul 1, 2024
f604c11
[#12872] Warn instructors not to share link with students (#13137)
itstrueitstrueitsrealitsreal Jul 5, 2024
836f637
[#12578] `@` sign is shown as `@` when viewing essay question sub…
Respirayson Jul 7, 2024
399a5fa
[#12779] Fix notifications update logic (#13083)
marquestye Jul 8, 2024
c5af284
[#12894] Calculate msq totals by student email instead of name (#13141)
itstrueitstrueitsrealitsreal Jul 10, 2024
13a1891
[#12048] Migrate InstructorCourseStudentDetailsEditPageE2ETest (#13069)
weiquu Jul 10, 2024
3f5f68d
[#13104] Accounts request form: auto-unify country names (#13117)
franciscoSavala Jul 11, 2024
61df45a
[#12655] Instructor Edit Session Page: If make session visible is lat…
Respirayson Jul 15, 2024
67628fb
[#12749] Autosave and restore progress if user navigates away (#13140)
Respirayson Jul 23, 2024
6b7912c
[#12588] Test coverage improvements for InstructorResponsesViewBase (…
justinsegawa Jul 24, 2024
9181467
[#13147] Didn't Account for the Timezone in Session Edit Form compone…
Respirayson Jul 26, 2024
05f0e5e
Add check for closed issue
itstrueitstrueitsrealitsreal Jul 27, 2024
fca9e1f
Update message
itstrueitstrueitsrealitsreal Jul 27, 2024
f0c91b7
Rephrase message
itstrueitstrueitsrealitsreal Jul 27, 2024
699a00a
Add logging
itstrueitstrueitsrealitsreal Jul 27, 2024
d011c16
Test
itstrueitstrueitsrealitsreal Jul 27, 2024
bb3062e
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
03cc085
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
a39ba95
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
566a0a5
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
73d1393
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
42893ce
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
d05878e
Resolve merge conflicts
itstrueitstrueitsrealitsreal Jul 27, 2024
7c0c9ef
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
f4d428c
Resolve merge conflicts
itstrueitstrueitsrealitsreal Jul 27, 2024
26ee2b5
Add check for closed issue
itstrueitstrueitsrealitsreal Jul 27, 2024
686027b
[#13147] Didn't Account for the Timezone in Session Edit Form compone…
Respirayson Jul 26, 2024
cbb6e6f
Update pr.yml
itstrueitstrueitsrealitsreal Jul 27, 2024
f9ecd69
Merge branch 'automation' of https://github.com/itstrueitstrueitsreal…
itstrueitstrueitsrealitsreal Jul 27, 2024
01292f2
Update workflow
itstrueitstrueitsrealitsreal Jul 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TEAMMATES#12894] Calculate msq totals by student email instead of na…
…me (TEAMMATES#13141)

* Calculate totals by email

* Standardize mcq and msq

* Undo sortBy

* Refactor initialization of variables

---------

Co-authored-by: domoberzin <[email protected]>
itstrueitstrueitsrealitsreal and domoberzin authored Jul 10, 2024
commit c5af284c2d3fe059472e2826de19eb2d025ec09a
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ export class MsqQuestionStatisticsComponent extends MsqQuestionStatisticsCalcula
{ header: 'Recipient Name', sortBy: SortBy.MSQ_RECIPIENT_NAME },
...Object.keys(this.weightPerOption).map((key: string) => {
return {
header: `${key} [${this.weightPerOption[key]}]`,
header: `${key} [${(this.weightPerOption[key]).toFixed(2)}]`,
sortBy: SortBy.MSQ_OPTION_SELECTED_TIMES,
};
}),
@@ -83,8 +83,8 @@ export class MsqQuestionStatisticsComponent extends MsqQuestionStatisticsCalcula
value: this.perRecipientResponses[key].responses[option],
};
}),
{ value: this.perRecipientResponses[key].total },
{ value: this.perRecipientResponses[key].average },
{ value: (this.perRecipientResponses[key].total).toFixed(2) },
{ value: (this.perRecipientResponses[key].average).toFixed(2) },
];
});
}
Original file line number Diff line number Diff line change
@@ -91,19 +91,29 @@ export class MsqQuestionStatisticsCalculation
const perRecipientResponse: Record<string, Record<string, number>> = {};
const recipientToTeam: Record<string, string> = {};
const recipientEmails: Record<string, string> = {};
const recipientNames: Record<string, string> = {};
for (const response of this.responses) {
perRecipientResponse[response.recipient] = perRecipientResponse[response.recipient] || {};
recipientEmails[response.recipient] = recipientEmails[response.recipient] || response.recipientEmail || '';
const responseEmail = response.recipientEmail;
if (!responseEmail) {
continue;
}
perRecipientResponse[responseEmail] = perRecipientResponse[responseEmail] || {};
recipientEmails[responseEmail] = recipientEmails[responseEmail] || responseEmail || '';
recipientNames[responseEmail] = recipientNames[responseEmail] || response.recipient || '';
for (const choice of this.question.msqChoices) {
perRecipientResponse[response.recipient][choice] = 0;
perRecipientResponse[responseEmail][choice] = 0;
}
if (this.question.otherEnabled) {
perRecipientResponse[response.recipient]['Other'] = 0;
perRecipientResponse[responseEmail]['Other'] = 0;
}
recipientToTeam[response.recipient] = response.recipientTeam;
recipientToTeam[responseEmail] = response.recipientTeam;
}
for (const response of this.responses) {
this.updateResponseCountPerOptionForResponse(response.responseDetails, perRecipientResponse[response.recipient]);
const email = response.recipientEmail;
if (!email) {
continue;
}
this.updateResponseCountPerOptionForResponse(response.responseDetails, perRecipientResponse[email]);
}

for (const recipient of Object.keys(perRecipientResponse)) {
@@ -120,7 +130,7 @@ export class MsqQuestionStatisticsCalculation
average = numOfResponsesForRecipient ? total / numOfResponsesForRecipient : 0;

this.perRecipientResponses[recipient] = {
recipient,
recipient: recipientNames[recipient],
recipientEmail: recipientEmails[recipient],
total: +total.toFixed(5),
average: +average.toFixed(2),
Original file line number Diff line number Diff line change
@@ -100,7 +100,7 @@
}
],
"expectedPerRecipientResponses": {
"Alice": {
"[email protected]": {
"average": 1.5,
"recipient": "Alice",
"recipientEmail": "[email protected]",
@@ -112,7 +112,7 @@
},
"total": 3
},
"Bob": {
"[email protected]": {
"average": 1,
"recipient": "Bob",
"recipientEmail": "[email protected]",
@@ -124,7 +124,7 @@
},
"total": 1
},
"Charles": {
"[email protected]": {
"average": 0,
"recipient": "Charles",
"recipientEmail": "[email protected]",
@@ -138,7 +138,7 @@
}
},
"expectedPerRecipientResponsesWithOther": {
"Alice": {
"[email protected]": {
"average": 2,
"recipient": "Alice",
"recipientEmail": "[email protected]",
@@ -151,7 +151,7 @@
},
"total": 6
},
"Bob": {
"[email protected]": {
"average": 2.5,
"recipient": "Bob",
"recipientEmail": "[email protected]",
@@ -164,7 +164,7 @@
},
"total": 5
},
"Charles": {
"[email protected]": {
"average": 0,
"recipient": "Charles",
"recipientEmail": "[email protected]",