-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release: v1.0.6 #2801
Prepare release: v1.0.6 #2801
Conversation
WalkthroughOhayo, sensei! This pull request primarily updates the version numbers across several configuration files, specifically from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
Cargo.lock
is excluded by!**/*.lock
crates/dojo/core/Scarb.lock
is excluded by!**/*.lock
crates/torii/types-test/Scarb.lock
is excluded by!**/*.lock
examples/spawn-and-move/Scarb.lock
is excluded by!**/*.lock
📒 Files selected for processing (5)
Cargo.toml
(1 hunks)crates/dojo/core/Scarb.toml
(1 hunks)crates/torii/server/Cargo.toml
(1 hunks)crates/torii/types-test/Scarb.toml
(1 hunks)examples/spawn-and-move/Scarb.toml
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- examples/spawn-and-move/Scarb.toml
- Cargo.toml
- crates/dojo/core/Scarb.toml
- crates/torii/server/Cargo.toml
@@ -2,7 +2,7 @@ | |||
cairo-version = "=2.8.4" | |||
edition = "2024_07" | |||
name = "types_test" | |||
version = "1.0.5" | |||
version = "1.0.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Ohayo sensei! Found some version inconsistencies that need attention!
The version update to 1.0.6 is not consistent across all packages. Here are the mismatched versions:
crates/dojo/core-cairo-test/Scarb.toml
: version = "1.0.0-rc.0"crates/benches/contracts/Scarb.toml
: version = "1.0.0-rc.0"examples/simple/Scarb.toml
: version = "0.1.0"examples/game-lib/*/Scarb.toml
: version = "0.1.0"crates/katana/contracts/Scarb.toml
: version = "0.1.0"
While some packages might intentionally have different versions, the core packages should be aligned with the 1.0.6 release.
🔗 Analysis chain
Ohayo sensei! Version bump looks good!
The version update to 1.0.6 aligns with the release preparation.
Let's verify version consistency across all configuration files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across Scarb.toml and Cargo.toml files
echo "Checking Scarb.toml files..."
fd -e toml -x grep -l "version = " {} | while read -r file; do
echo "=== $file ==="
grep "version = " "$file"
done
echo -e "\nChecking Cargo.toml files..."
fd Cargo.toml -x grep -l "version = " {} | while read -r file; do
echo "=== $file ==="
grep "version = " "$file"
done
Length of output: 17405
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
==========================================
- Coverage 55.75% 55.74% -0.01%
==========================================
Files 439 439
Lines 55572 55572
==========================================
- Hits 30983 30978 -5
- Misses 24589 24594 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: glihm <[email protected]>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
1.0.5
to1.0.6
, indicating a new release.Chores
Cargo.toml
file for thetorii-server
package for better formatting.