Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v1.0.6 #2801

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Prepare release: v1.0.6 #2801

merged 1 commit into from
Dec 12, 2024

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Dec 12, 2024

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • New Features

    • Updated version numbers for multiple packages from 1.0.5 to 1.0.6, indicating a new release.
  • Chores

    • Added a newline at the end of the Cargo.toml file for the torii-server package for better formatting.

Copy link

coderabbitai bot commented Dec 12, 2024

Walkthrough

Ohayo, sensei! This pull request primarily updates the version numbers across several configuration files, specifically from 1.0.5 to 1.0.6. The changes are reflected in the Cargo.toml files for the workspace and the torii packages, as well as in the Scarb.toml files for various components of the Dojo project. No new dependencies were introduced, and the overall structure of the configuration files remains unchanged.

Changes

File Path Change Summary
Cargo.toml Version updated from 1.0.5 to 1.0.6.
crates/dojo/core/Scarb.toml Version updated from 1.0.5 to 1.0.6.
crates/torii/server/Cargo.toml Added a newline at the end of the file.
crates/torii/types-test/Scarb.toml Version updated from 1.0.5 to 1.0.6.
examples/spawn-and-move/Scarb.toml Version updated from 1.0.5 to 1.0.6.

Possibly related PRs

Suggested reviewers

  • glihm

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 133feec and da9843e.

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo/core/Scarb.lock is excluded by !**/*.lock
  • crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • Cargo.toml (1 hunks)
  • crates/dojo/core/Scarb.toml (1 hunks)
  • crates/torii/server/Cargo.toml (1 hunks)
  • crates/torii/types-test/Scarb.toml (1 hunks)
  • examples/spawn-and-move/Scarb.toml (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • examples/spawn-and-move/Scarb.toml
  • Cargo.toml
  • crates/dojo/core/Scarb.toml
  • crates/torii/server/Cargo.toml

@@ -2,7 +2,7 @@
cairo-version = "=2.8.4"
edition = "2024_07"
name = "types_test"
version = "1.0.5"
version = "1.0.6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo sensei! Found some version inconsistencies that need attention!

The version update to 1.0.6 is not consistent across all packages. Here are the mismatched versions:

  • crates/dojo/core-cairo-test/Scarb.toml: version = "1.0.0-rc.0"
  • crates/benches/contracts/Scarb.toml: version = "1.0.0-rc.0"
  • examples/simple/Scarb.toml: version = "0.1.0"
  • examples/game-lib/*/Scarb.toml: version = "0.1.0"
  • crates/katana/contracts/Scarb.toml: version = "0.1.0"

While some packages might intentionally have different versions, the core packages should be aligned with the 1.0.6 release.

🔗 Analysis chain

Ohayo sensei! Version bump looks good!

The version update to 1.0.6 aligns with the release preparation.

Let's verify version consistency across all configuration files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version consistency across Scarb.toml and Cargo.toml files

echo "Checking Scarb.toml files..."
fd -e toml -x grep -l "version = " {} | while read -r file; do
  echo "=== $file ==="
  grep "version = " "$file"
done

echo -e "\nChecking Cargo.toml files..."
fd Cargo.toml -x grep -l "version = " {} | while read -r file; do
  echo "=== $file ==="
  grep "version = " "$file"
done

Length of output: 17405

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.74%. Comparing base (133feec) to head (da9843e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
- Coverage   55.75%   55.74%   -0.01%     
==========================================
  Files         439      439              
  Lines       55572    55572              
==========================================
- Hits        30983    30978       -5     
- Misses      24589    24594       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit ba8ff05 into main Dec 12, 2024
13 of 14 checks passed
@glihm glihm deleted the prepare-release branch December 12, 2024 16:39
kariy pushed a commit that referenced this pull request Dec 13, 2024
@coderabbitai coderabbitai bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants