Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v1.0.4 #2756

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Prepare release: v1.0.4 #2756

merged 1 commit into from
Dec 3, 2024

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Dec 3, 2024

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • New Features
    • Incremented version number for multiple packages from 1.0.3 to 1.0.4, indicating a new release.
  • Bug Fixes
    • No new bugs introduced; existing dependencies and configurations remain unchanged across various packages.

Copy link

coderabbitai bot commented Dec 3, 2024

Walkthrough

Ohayo, sensei! This pull request includes updates to several Scarb.toml files across different packages, primarily focusing on incrementing the version number from 1.0.3 to 1.0.4. The changes are administrative, ensuring that the existing structure of dependencies and configurations remains intact without introducing new functionalities or altering any existing elements.

Changes

File Change Summary
Cargo.toml Version updated from 1.0.3 to 1.0.4.
crates/dojo/core/Scarb.toml Version updated from 1.0.3 to 1.0.4.
crates/torii/types-test/Scarb.toml Version updated from 1.0.3 to 1.0.4.
examples/spawn-and-move/Scarb.toml Version updated from 1.0.3 to 1.0.4.

Possibly related PRs

Suggested reviewers

  • glihm

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2026f58 and 62af05f.

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo/core/Scarb.lock is excluded by !**/*.lock
  • crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • crates/dojo/core/Scarb.toml (1 hunks)
  • crates/torii/types-test/Scarb.toml (1 hunks)
  • examples/spawn-and-move/Scarb.toml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • crates/torii/types-test/Scarb.toml
  • crates/dojo/core/Scarb.toml
🔇 Additional comments (2)
examples/spawn-and-move/Scarb.toml (1)

4-4: Ohayo sensei! Version update looks good! ✨

The version bump from 1.0.3 to 1.0.4 is consistent with the release preparation.

Cargo.toml (1)

62-62: Ohayo sensei! Version update is properly synchronized! 🎋

The workspace version bump to 1.0.4 aligns perfectly with the Scarb.toml update.

Let's verify version consistency across all Scarb.toml files:

✅ Verification successful

Ohayo sensei! Found some version mismatches that need attention! 🎋

The version consistency check revealed mismatches across the codebase:

  • Main workspace version (1.0.4) doesn't match with:
    • examples/simple/Scarb.toml: version 0.1.0
    • examples/game-lib/*/Scarb.toml: version 0.1.0
    • crates/dojo/core-cairo-test/Scarb.toml: version 1.0.0-rc.0
    • crates/benches/contracts/Scarb.toml: version 1.0.0-rc.0

However, this appears to be intentional as examples and test contracts commonly use different versions. The critical files (crates/torii/types-test/Scarb.toml, examples/spawn-and-move/Scarb.toml, and crates/dojo/core/Scarb.toml) are correctly synchronized at version 1.0.4.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any mismatched versions in Scarb.toml files
echo "Checking version consistency across Scarb.toml files..."
fd -e toml -x grep -l "version = " {} \; | xargs grep "version = "

Length of output: 6784


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glihm glihm merged commit 2dd561a into main Dec 3, 2024
12 checks passed
@glihm glihm deleted the prepare-release branch December 3, 2024 17:12
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.69%. Comparing base (2026f58) to head (62af05f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   55.46%   54.69%   -0.77%     
==========================================
  Files         427      427              
  Lines       53620    53919     +299     
==========================================
- Hits        29738    29492     -246     
- Misses      23882    24427     +545     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

augustin-v pushed a commit to augustin-v/dojo that referenced this pull request Dec 4, 2024
This was referenced Dec 6, 2024
@coderabbitai coderabbitai bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants