-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release: v1.0.5 #2774
Prepare release: v1.0.5 #2774
Conversation
WalkthroughOhayo, sensei! The pull request primarily involves version updates across multiple Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Cargo.toml (1)
Ohayo sensei! Time to update that git dependency! 🎯
The crate
ipfs-api-backend-hyper
is available on crates.io with version 0.6.0, while the project is currently using a git dependency with a specific commit. You can replace the git dependency with the published version:ipfs-api-backend-hyper = { version = "0.6.0", features = ["with-hyper-rustls", "with-send-sync"] }🔗 Analysis chain
Line range hint
251-252
: TODO comment needs attention, sensei! 🤔There's a TODO comment regarding the git version of
ipfs-api-backend-hyper
. Consider evaluating if the git dependency is still necessary or if we can switch to a published version.Let's check if there's a published version available:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for published versions of ipfs-api-backend-hyper # Check crates.io for published versions curl -s https://crates.io/api/v1/crates/ipfs-api-backend-hyper | jq '.crate.max_version'Length of output: 96
Script:
#!/bin/bash # Let's check the actual dependency in Cargo.toml to see if it's using git rg "ipfs-api-backend-hyper" -A 2 Cargo.tomlLength of output: 249
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (4)
Cargo.lock
is excluded by!**/*.lock
crates/dojo/core/Scarb.lock
is excluded by!**/*.lock
crates/torii/types-test/Scarb.lock
is excluded by!**/*.lock
examples/spawn-and-move/Scarb.lock
is excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml
(1 hunks)crates/dojo/core/Scarb.toml
(1 hunks)crates/torii/types-test/Scarb.toml
(1 hunks)examples/spawn-and-move/Scarb.toml
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- crates/torii/types-test/Scarb.toml
- examples/spawn-and-move/Scarb.toml
- crates/dojo/core/Scarb.toml
🔇 Additional comments (1)
Cargo.toml (1)
62-62
: Ohayo sensei! Version bump looks good! 🎉
The version update from 1.0.4
to 1.0.5
aligns with the release preparation objective.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
=======================================
Coverage 56.01% 56.02%
=======================================
Files 434 434
Lines 55068 55068
=======================================
+ Hits 30847 30851 +4
+ Misses 24221 24217 -4 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
1.0.5
, ensuring users have access to the latest features and improvements.Bug Fixes
Documentation