JobAccountant workaround for StepChain jobs with duplicate files - wmagent branch #10486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch has been pushed in in all 1.4.7 production agents. |
|
A few patches have been accumulated, so I'm going to make a patch4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #9633 (real fix still needs to be created against master)
Status
ready (tested in submit7)
Description
Please read the last comment in the GH issue for further details on the actual root cause of this problem.
With this PR, we do not inject output files into the database if they came without any location in the FJR.
Which is the case for StepChain jobs that crash in the worker node, thus not actually staging those files out to the storage area (and getting an unique file id).
Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none