Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobAccountant workaround for StepChain jobs with duplicate files - wmagent branch #10486

Merged
merged 1 commit into from
Jul 1, 2021
Merged

JobAccountant workaround for StepChain jobs with duplicate files - wmagent branch #10486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/python/WMComponent/JobAccountant/AccountantWorker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,8 @@ def handleJob(self, jobID, fwkJobReport):
conn=self.getDBConn(),
transaction=self.existingTransaction())

# FIXME: temporary workaround for: https://github.com/dmwm/WMCore/issues/9633
skipOutputFiles = False
if jobSuccess:
fileList = fwkJobReport.getAllFiles()

Expand Down Expand Up @@ -504,6 +506,7 @@ def handleJob(self, jobID, fwkJobReport):
if not fwjrFile.get("locations") and fwjrFile.get("lfn", "").endswith(".root"):
logging.warning("The following file doesn't have any location: %s", fwjrFile)
jobSuccess = False
skipOutputFiles = True
break
else:
fileList = fwkJobReport.getAllFilesFromStep(step='logArch1')
Expand Down Expand Up @@ -548,6 +551,12 @@ def handleJob(self, jobID, fwkJobReport):
else:
wmbsJob["outcome"] = "failure"

# FIXME: BAD HACK to avoid crashing the component
if skipOutputFiles:
logging.warning("Skipping output file registration for failed job: %d", jobID)
self.listOfJobsToFail.append(wmbsJob)
return jobSuccess

for fwjrFile in fileList:

logging.debug("Job %d , register output %s", jobID, fwjrFile["lfn"])
Expand Down