Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add build-doc job to test building docs. #227

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This doesn't use nightly (like docs.rs does) because there are other warnings on nightly builds that would break this.

Also, I used parallel here but that isn't tested yet by other build configs.

@waywardmonkeys
Copy link
Contributor Author

This will fail until #226 is landed.

with:
toolchain: stable
- name: cargo doc
run: cargo doc --workspace --features bytemuck-serialize,serde-serialize,rkyv-serialize,parallel --no-deps --document-private-items
Copy link
Contributor

@Vrixyz Vrixyz Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features addition is a good addition compared to #224

@Vrixyz
Copy link
Contributor

Vrixyz commented Jul 19, 2024

This will fail until #226 is landed.

and #235 too.

@sebcrozet sebcrozet force-pushed the ci-add-docs-validation branch from 050304f to de3f10f Compare July 20, 2024 14:17
@sebcrozet
Copy link
Member

Thank you! I rebased on top of master after merging your other fixes. All green now ✅

@sebcrozet sebcrozet merged commit e5f20d3 into dimforge:master Jul 20, 2024
6 checks passed
@waywardmonkeys waywardmonkeys deleted the ci-add-docs-validation branch July 21, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants