-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use a regular cargo
to build no-std targets.
#231
Conversation
This will conflict with #227, but I'm happy to fix up any merge conflicts after whichever lands first. |
d373427
to
0cee0d3
Compare
`xargo` is no longer needed and has been in maintenance mode for over 7 years. This can run on `stable` rather than requiring `nightly` The build doesn't need `rustfmt`, so don't require that it be installed.
0cee0d3
to
fd785c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, but I have a minor concern over dropping nightly compilation: that means we don't have any ci testing nightly.
It's most definitely correct for this PR, but should we add a periodic CI step on master to test against nightly ? @sebcrozet
Thank you for this PR @waywardmonkeys ! Back in the days,
@Vrixyz We should keep a nightly test (on PRs) that checkes the simd-nightly feature. (But, yes, this should be in a separate PR.) |
Yes. Using This is what we do in |
As an aside, this would be a great time to bring up the work started in PR #170 and see about finding a victim to do more of that. :) |
Is this related to the failure I'm seeing in #249 ? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for checking @waywardmonkeys! Looks good.
xargo
is no longer needed and has been in maintenance mode for over 7 years.This can run on
stable
rather than requiringnightly
The build doesn't need
rustfmt
, so don't require that it be installed.