Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo doc ci #224

Closed
wants to merge 1 commit into from
Closed

cargo doc ci #224

wants to merge 1 commit into from

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Jul 15, 2024

No description provided.

@Vrixyz Vrixyz requested a review from sebcrozet July 15, 2024 19:40
@waywardmonkeys
Copy link
Contributor

I hadn't seen this when I pushed my #226 and #227 ... my approach in #227 is slightly different, so it is worth comparing them.

Comment on lines +32 to +34
- uses: Swatinem/rust-cache@v2
with:
prefix-key: ${{ env.RUST_CACHE_KEY }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that for consistency with rapier, but it might not be necessary 🤔 , I like the more straightforward approach of #227

Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I approved it, but feel free to merge #227 (or a combination of the two) if that sounds better.
I agree that compiling with some features enabled is more robust.

@sebcrozet
Copy link
Member

#224 got merged so I believe we can close this one. Feel free to reopen otherwise.

@sebcrozet sebcrozet closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants