Simplify canister state lifecycle #6302
Open
+179
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-4
branch
from
46cd53b to
527e236
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-3
branch
2 times, most recently
from
d5dc422 to
00893e4
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-4
branch
2 times, most recently
from
494327d to
3b7de2f
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…6301) # Motivation `accounts_db_stats_recomputed_on_upgrade` is no longer useful after the migration of accounts to stable structures. It is always `opt false`, which can be verified by `dfx canister --ic call qoctq-giaaa-aaaaa-aaaea-cai get_stats | grep accounts_db_stats_recomputed_on_upgrade` # Changes Remove everything related to `accounts_db_stats_recomputed_on_upgrade` # Tests N/A # Related PRs [Previous](#6298) | [Next](#6302)
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-4
branch
2 times, most recently
from
e527938 to
46a8a44
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-4
branch
from
46a8a44 to
042e60f
Compare
jasonz-dfinity
commented
Jan 31, 2025
Comment on lines
+44
to
+49
| let expected_accounts: BTreeMap<_, _> = accounts_store.range(..).collect(); | ||
| let mut expected_account_stats = Stats::default(); | ||
| accounts_store.get_stats(&mut expected_account_stats); | ||
| let expected_assets = assets.clone(); | ||
| let expected_tvl_state = tvl_state.clone(); | ||
| let expected_asset_hashes = asset_hashes.clone(); |
There was a problem hiding this comment.
Note: this is a side effect of doing a conversion from State to SerializableState, since during the conversion, State is destroyed, so we need to clone parts of the state before consuming it. An alternative is impl From<&State> for SerializableState. However, this would worsen the production code, since the conversion would have to clone data unnecessarily. The downside of having to clone the parts of the state for comparison in a unit test seems to acceptable.
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-4
branch
4 times, most recently
from
ad26122 to
19088a5
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-4
branch
from
19088a5 to
b6bbedc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When deserializing the
Stateand reconstruct it, anAccountsDbAsMapis first created when deserializing, then gets replaced withAccountsDbAsUnboundedStableBTreeMap. This makes the removal ofAccountsDbAsMap(which is no longer used in production difficult.Changes
thread_local!variableStateState(conversion->)SerializableStateSerializableState(encode ->)Vec<u8>Vec<u8>Vec<u8>(decode ->)SerializableStateSerializableState(conversion->)StateTests
N/A since there are no functionality changes. The test in
rs/backend/src/state/tests.rsshould (still) cover the code being changed in this PR.Related PRs
Previous | Next