Remove everything related to accounts_db_stats_recomputed_on_upgrade #6301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-3
branch
from
6bdcbb4 to
8750949
Compare
dskloetd
approved these changes
Jan 31, 2025
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-2
branch
from
5c0a83c to
fe325f0
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-3
branch
from
8750949 to
d5dc422
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…Maybe (#6298) # Motivation `Partitions` is already "global", in the sense that even in unit tests ([ic_stable_structures::VectorMemory](https://github.com/dfinity/stable-structures/blob/69ed47f9b5001af67d650c714cd56ec3ee0ef2bb/src/lib.rs#L38)) is an `Rc<RefCell<Vec<u8>>>`, and operations to various memory partitions read/write from/to the bytes owned by the `Rc`. Therefore, it makes sense for `Partitions` to be a `thread_local!` variable. On the other hand, `PartitionsMaybe` is only useful when there can be 2 cases (raw/managed memory), which is no longer the case after the migration. # Changes 1. Define `PARTITIONS` `thread_local` variable and add accessors 2. Remove everything related to `PartitionsMaybe` and simplify dead code # Tests N/A since it's mostly trivial refactoring. Tests under `rs/backend/src/state/tests.rs` should cover the code changed in this PR. # Related PRs [Previous](#6297) | [Next](#6301)
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-3
branch
from
d5dc422 to
00893e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
accounts_db_stats_recomputed_on_upgradeis no longer useful after the migration of accounts to stable structures. It is alwaysopt false, which can be verified bydfx canister --ic call qoctq-giaaa-aaaaa-aaaea-cai get_stats | grep accounts_db_stats_recomputed_on_upgradeChanges
Remove everything related to
accounts_db_stats_recomputed_on_upgradeTests
N/A
Related PRs
Previous | Next