Persist Partitions into a thread_local variable and remove PartitionsMaybe #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-2
branch
from
9e5fc9f to
7522862
Compare
This was referenced Jan 31, 2025
dskloetd
approved these changes
Jan 31, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
# Motivation 2 reasons for this refactoring: 1. The backup/restore of `State` is currently a bit convoluted - it creates an AccountsStore with `AccountsDbAsMap` and replace it with `AccountsDbAsUnboundedStableBTreeMap` afterwards. This will be changed in a future PR. However, the functionalities of reading/writing bytes from/to managed memory are clear and useful, so they are moved to separate functions. 2. `PartitionsMaybe` will be removed, and the `Partitions` will be moved out of `State` in the next PR. When that happens, it makes less sense to have the logic to read/write managed memory in `State`, but rather `Partitions`. `State` will mostly care about how itself can be encoded/decoded # Changes Extract reading/writing bytes logic from `save_heap_to_managed_memory`/`recover_heap_from_managed_memory` to `Partition` methods # Tests Added tests for newly extracted methods # Todos - [x] Add entry to changelog (if necessary). # Related PRs [Next](#6298)
jasonz-dfinity
force-pushed
the
jason/NNS1-3030-2
branch
from
5c0a83c to
fe325f0
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…6301) # Motivation `accounts_db_stats_recomputed_on_upgrade` is no longer useful after the migration of accounts to stable structures. It is always `opt false`, which can be verified by `dfx canister --ic call qoctq-giaaa-aaaaa-aaaea-cai get_stats | grep accounts_db_stats_recomputed_on_upgrade` # Changes Remove everything related to `accounts_db_stats_recomputed_on_upgrade` # Tests N/A # Related PRs [Previous](#6298) | [Next](#6302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partitionsis already "global", in the sense that even in unit tests (ic_stable_structures::VectorMemory) is anRc<RefCell<Vec<u8>>>, and operations to various memory partitions read/write from/to the bytes owned by theRc. Therefore, it makes sense forPartitionsto be athread_local!variable. On the other hand,PartitionsMaybeis only useful when there can be 2 cases (raw/managed memory), which is no longer the case after the migration.Changes
PARTITIONSthread_localvariable and add accessorsPartitionsMaybeand simplify dead codeTests
N/A since it's mostly trivial refactoring. Tests under
rs/backend/src/state/tests.rsshould cover the code changed in this PR.Related PRs
Previous | Next