Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nodejs icon with devfile-stack-icons link #338

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 20, 2024

What does this PR do?:

Replaces the broken icon for nodejs stack with the one added in the devfile-stack-icons repo.

Which issue(s) this PR fixes:

Fixes devfile/api#1484

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@thepetk thepetk requested a review from michael-valdron March 20, 2024 10:30
@openshift-ci openshift-ci bot requested a review from BethGriggs March 20, 2024 10:30
@thepetk thepetk changed the title [DO NOT MERGE] Replace nodejs icon with devfile-stack-icons link Replace nodejs icon with devfile-stack-icons link Mar 20, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Mar 20, 2024

/retest

@thepetk
Copy link
Contributor Author

thepetk commented Mar 20, 2024

@BethGriggs could you please review the PR as you are the owner of the nodejs stack?

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Mar 20, 2024
@michael-valdron michael-valdron mentioned this pull request Mar 20, 2024
4 tasks
Copy link

openshift-ci bot commented Mar 21, 2024

@lholmquist: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lholmquist, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk
Copy link
Contributor Author

thepetk commented Mar 21, 2024

Merging as the PR is approved by @lholmquist (member of the team owning the stack)

@thepetk thepetk merged commit 27951b4 into devfile:main Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Node.js stack/sample icon links
3 participants