-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nodejs icon link with devfile-stack-icons link #226
Conversation
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 27.27% 27.27%
=======================================
Files 7 7
Lines 2009 2009
=======================================
Hits 548 548
Misses 1414 1414
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Please specify the area for this PR
/area registry
/area test-automation
What does does this PR do / why we need it:
Simply updates the broken nodejs icon link used inside the registry support tests. Follows the same fix of devfile/registry#338
Which issue(s) this PR fixes:
Fixes devfile/api#1484
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: