Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nodejs icon link with devfile-stack-icons link #226

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 21, 2024

Please specify the area for this PR

/area registry
/area test-automation

What does does this PR do / why we need it:

Simply updates the broken nodejs icon link used inside the registry support tests. Follows the same fix of devfile/registry#338

Which issue(s) this PR fixes:

Fixes devfile/api#1484

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Mar 21, 2024

@thepetk: The label(s) area/registry, area/test-automation cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area registry
/area test-automation

What does does this PR do / why we need it:

Simply updates the broken nodejs icon link used inside the registry support tests. Follows the same fix of devfile/registry#338

Which issue(s) this PR fixes:

Fixes devfile/api#1484

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from elsony and Jdubrick March 21, 2024 15:56
@thepetk thepetk requested review from michael-valdron and removed request for elsony March 21, 2024 15:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
Copy link

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.27%. Comparing base (9445a83) to head (6419198).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   27.27%   27.27%           
=======================================
  Files           7        7           
  Lines        2009     2009           
=======================================
  Hits          548      548           
  Misses       1414     1414           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk thepetk merged commit 34df2fe into devfile:main Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Node.js stack/sample icon links
3 participants