add deprecation to nodejs 16 #337
Conversation
|
/retest |
|
/hold This is going to need to be merged after the nodejs issue is fixed devfile/api#1484 |
There was a problem hiding this comment.
I think based on what we have discussed for devfile/api#1482 for the stacks we update the default version we can make the new default their latest version. WDYT?
That's okay with me, I know I just bumped them all up 1 but can update it to bump them all to latest. I'm going to also mark the issue as blocked since it isn't going to pass PR checks with the nodejs icon issue cc @thepetk |
|
/retest |
|
/retest |
|
/unhold #338 should have unblocked this PR. |
|
Will re run tests in a little bit, seems like the issue is still occuring but I don't know maybe it hasn't updated yet to CI. https://github.com/devfile/registry/actions/runs/8348517850/job/22941030162?pr=337 |
Most likely, |
|
@lholmquist Need your quick review on the changes done to the FYI @Jdubrick |
|
@lholmquist: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Jdubrick
force-pushed
the
nodejs-deprecation
branch
from
0b693a3 to
358ac44
Compare
@michael-valdron i was trying to figure out why the builds were still failing, thank you. Just rebased so hopefully this fixes the issue! edit: svelte change added a different default version and my rebase didnt notify me of that |
Signed-off-by: Jordan Dubrick <[email protected]>
|
@michael-valdron looks like the rebase and nodejs changes allowed checks to pass |
|
@thepetk in response to your reviews the defaults were just bumped up 1 version from the one that was deprecated in this case. This was done before any discussion surrounding if we should keep the default updated to the latest version. wdyt? |
I'd say in order to avoid back & forth for this PR we can move the default to latest with a separate PR! |
There was a problem hiding this comment.
/lgtm as @michael-valdron requested changes I'd wait for his approval too :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, lholmquist, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
This PR adds the
Deprecatedtag to stacks with theNodejs 16image. It also adds these deprecated stacks to therenovate.jsonexclusion list and bumps the default version for all changed stacks up by 1 so the default version is not a deprecated stack.Which issue(s) this PR fixes:
Link to github issue(s)
fixes devfile/api#1364
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: