Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate stack versions with images using node.js 16 #1364

Closed
2 tasks
thepetk opened this issue Nov 28, 2023 · 4 comments · Fixed by devfile/registry#337
Closed
2 tasks

Deprecate stack versions with images using node.js 16 #1364

thepetk opened this issue Nov 28, 2023 · 4 comments · Fixed by devfile/registry#337
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure good first issue Good for newcomers

Comments

@thepetk
Copy link
Contributor

thepetk commented Nov 28, 2023

Which area/kind this issue is related to?

/area registry

Issue Description

As seen in the nodejs.org the Node.js 16 has reached its end-of-life date (September 11th, 2023). The api#1300 has introduced the Deprecated label to stacks.

That said, we can also add the same label to specific stack versions using images with node.js 16. An easy way to identify them is the renovate bot updates here. Therefore, those stacks are:

  • nodejs-angular/2.0.2
  • nodejs-nextjs/1.0.3
  • nodejs-nuxtjs/1.0.3
  • nodejs-react/2.0.2
  • nodejs-svelte/1.0.3
  • nodejs-vue/1.0.2
  • nodejs/2.1.1

Acceptance Criteria

  • The Deprecated tag has been added to the stack versions using images with node.js 16.
  • Exclude the deprecated stack versions paths from the renovate.json (exactly like the golang deprecated versions).
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Nov 28, 2023
@thepetk thepetk moved this to Backlog in Devfile Project Nov 28, 2023
@michael-valdron michael-valdron moved this from Backlog to Refinement in Devfile Project Nov 28, 2023
@michael-valdron michael-valdron added the good first issue Good for newcomers label Dec 21, 2023
@michael-valdron michael-valdron moved this from Refinement to Backlog in Devfile Project Dec 21, 2023
@Jdubrick Jdubrick self-assigned this Mar 18, 2024
@Jdubrick
Copy link
Contributor

Pulling into current sprint for myself as I can complete it before end of sprint. Needed another quick issue to work on while the registry support release process is in discussion phase and changes are being made.

@Jdubrick Jdubrick moved this from Backlog to In Progress 🚧 in Devfile Project Mar 19, 2024
@Jdubrick Jdubrick moved this from In Progress 🚧 to In Review 👀 in Devfile Project Mar 19, 2024
@michael-valdron
Copy link
Member

PR checks might be blocked by #1484

FYI @Jdubrick

@Jdubrick
Copy link
Contributor

PR checks might be blocked by #1484

FYI @Jdubrick

can confirm this is breaking the PR checks
https://github.com/devfile/registry/actions/runs/8348517850/job/22850619349?pr=337

@michael-valdron
Copy link
Member

No longer blocked: devfile/registry#337 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure good first issue Good for newcomers
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

3 participants