-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert select all #10208
chore: revert select all #10208
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc45518
to
f477465
Compare
f477465
to
fa4827f
Compare
fa4827f
to
b470223
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10208 +/- ##
==========================================
- Coverage 53.88% 53.67% -0.21%
==========================================
Files 1257 1255 -2
Lines 156507 155708 -799
Branches 3653 3617 -36
==========================================
- Hits 84335 83582 -753
+ Misses 72039 71993 -46
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits look safe, and functionalities work as expected
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-0.38.0 release-0.38.0
# Navigate to the new working tree
cd .worktrees/backport-release-0.38.0
# Create a new branch
git switch --create backport-10208-to-release-0.38.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1894166a4e28f6f33c465571a8becf55cfab042
# Push it to GitHub
git push --set-upstream origin backport-10208-to-release-0.38.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-0.38.0 Then, create a pull request where the |
Ticket
N/A
Description
Reverting Select-All feature for the experiment list page. The select-all feature works with the frontend sending a custom query to the backend which parses the query and performs the action. This capability expands the net to be able to capture the entire matching set of experiments. Previously there was a bug which allowed an incorrect query to cause deletion of all experiments. For the purpose of winding down the codebase, we are removing this for stability reasons.
Test Plan
Basic idea of ensuring the behavior reverts back to how select all used to behave, which was that the select all chose all the experiments on a given page. So if users see experiments #26~#50 on page 2, it Select All would select experiments 26-50. However the selections are cumulative. So if the user navigates to a different page and select more, it would include new selections plus the original selection, BUT it only applies the API bulk action to the new selections.
Checklist
docs/release-notes/
See Release Note for details.