-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add actual select all to glide tables [ET-238] #10081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
force-pushed
the
emilybonar/actual-select-all
branch
2 times, most recently
from
October 21, 2024 17:45
09e247c
to
74db3c5
Compare
ashtonG
reviewed
Oct 21, 2024
ashtonG
reviewed
Oct 23, 2024
This reverts commit a07744b.
EmilyBonar
force-pushed
the
emilybonar/actual-select-all
branch
from
October 24, 2024 13:42
a53ea96
to
45aef30
Compare
ashtonG
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, we're close -- there are one or two places where we might have overlooked something.
i think consolidating selection state and operations is a good move.
ashtonG
approved these changes
Oct 24, 2024
EmilyBonar
requested review from
davidfluck-hpe
and removed request for
JComins000
October 25, 2024 18:02
davidfluck-hpe
approved these changes
Oct 25, 2024
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
hkang1
added a commit
that referenced
this pull request
Nov 18, 2024
hkang1
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-238
Ticket body:
Description
When selection header is clicked it selects all items on page
When "Select all runs in table" is clicked it selects all items in table
When selection header is clicked again it unselects all items on page
Test Plan
Checklist
docs/release-notes/
See Release Note for details.