feat: bulk actions matching filters (ET-241) #9895
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jesse-amano-hpe
force-pushed
the
jta/select-all-matching-filters-ET-241
branch
2 times, most recently
from
6528b04
to
72185dd
Compare
jesse-amano-hpe
requested review from
ShreyaLnuHpe and
AmanuelAaron
and removed request for
ShreyaLnuHpe
| IsTerminal bool | ||
| } | ||
|
|
||
| func filterSearchQuery(getQ *bun.SelectQuery, filter *string) (*bun.SelectQuery, error) { |
There was a problem hiding this comment.
Is there any difference between this function and the one in api_runs.go? If not maybe we can import it, or move it to a util file.
There was a problem hiding this comment.
The only difference is that since we're not querying the runs table to filter searches, we only look at WHERE NOT e.archived. Kind of a tricky thing to factor out but I'm open to thinking more on how we might consolidate this.
| Join("JOIN workspaces w ON p.workspace_id = w.id") | ||
| } | ||
|
|
||
| func (a *apiServer) MoveSearches( |
There was a problem hiding this comment.
Add tests for these new functions
There was a problem hiding this comment.
Done. Sorry it took so long!
|
Note from chatting with Alex today -- I'm going to add the tests, but we're going to let this sit unmerged until after the release cut next week (as it happens, I'm going to do the cutting) so we can have this endpoint included in the same wave of release party testing as the frontend feature it goes with instead of potentially doubling+ the QA work. |
jesse-amano-hpe
force-pushed
the
jta/select-all-matching-filters-ET-241
branch
from
72185dd
to
b975a5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9895 +/- ##
========================================
Coverage 54.40% 54.41%
========================================
Files 1261 1262 +1
Lines 158430 158880 +450
Branches 3631 3631
========================================
+ Hits 86201 86448 +247
- Misses 72095 72298 +203
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jesse-amano-hpe
force-pushed
the
jta/select-all-matching-filters-ET-241
branch
from
ef57707
to
a94569d
Compare
jesse-amano-hpe
force-pushed
the
jta/select-all-matching-filters-ET-241
branch
from
a94569d
to
3a5c3af
Compare
Ticket
ET-241
Description
Defines new endpoints for internal use, allowing the user to move/kill/pause/etc. searches using modern filter schema. The intention is to support a "true select-all" flow in ET-238 where the user sets up some filters, and then submits a bulk action request for all searches (multi-trial experiments) matching that filter.
Test Plan
Checklist
docs/release-notes/See Release Note for details.