Fix tutorial dataset paths #2340

julian-risch · 2022-03-21T17:15:49Z

I checked all tutorials and found a few problems.
Proposed changes:

Tutorial 4 and 8 weren't working because of the newly introduced doc_dir variable. They are working again with this PR.
Tutorial 10 didn't send an event because the dataset is not stored in our standard dataset directory. I included this non-standard url to our short list of known tutorial urls.
Tutorial 16 was missing the ocr dependencies and they are added now
Tutorial 15 uses a slightly different data path now to include tables AND texts now

Required changes addressed implemented in other PRs:

review-notebook-app · 2022-03-21T17:15:53Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

…ystack into fix_tutorial_dataset_paths

fix tutorial 4 dataset path

82e8ee6

julian-risch added type:bug Something isn't working topic:tutorials labels Mar 21, 2022

julian-risch requested a review from ZanSara March 21, 2022 17:15

julian-risch and others added 3 commits March 21, 2022 18:22

fix tutorial 8 dataset path

59f6c5d

fix tutorial 10 event

27ac021

Update Documentation & Code Style

b6be61b

julian-risch changed the title ~~fix tutorial 4 dataset path~~ Fix tutorial dataset paths Mar 21, 2022

ZanSara approved these changes Mar 21, 2022

View reviewed changes

julian-risch added 2 commits March 21, 2022 21:48

fix send event for tutorial 15

2d03983

Merge branch 'fix_tutorial_dataset_paths' of github.com:deepset-ai/ha…

fad7e58

…ystack into fix_tutorial_dataset_paths

julian-risch marked this pull request as ready for review March 21, 2022 20:51

Update Documentation & Code Style

0c2bf58

julian-risch merged commit 7ffecce into master Mar 22, 2022

julian-risch deleted the fix_tutorial_dataset_paths branch March 22, 2022 08:19

Provide feedback