Replace dpr with embeddingretriever tut14 #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| res_2 = transformer_question_classifier.run(query="Arya Stark was the daughter of a Lord.") | ||
| print("ES Results" + "\n" + "=" * 15) | ||
| print_answers(res_2, details="minimum") | ||
| print_documents(res_2) |
There was a problem hiding this comment.
Just found this bug myself. Great to see that you have already included the fix. 👍
|
@mkkuemmel I've just fixed 1 mini typo, can you have a look and if all good I'll approve and we can merge this. I agree with you on the complication of Tutorial 14 though (discussed offline) - But I think that's something we can create a separate issue and PR for. So here goes: Issue 2364 |
TuanaCelik
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):