Add evaluation and document conversion to tutorial 15 #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -95,7 +95,7 @@ Just as text passages, tables are represented as `Document` objects in Haystack. | |||
| from haystack.utils import fetch_archive_from_http | |||
|
|
|||
| doc_dir = "data" | |||
| s3_url = "https://s3.eu-central-1.amazonaws.com/deepset.ai-farm-qa/datasets/documents/ottqa_sample.zip" | |||
| s3_url = "https://s3.eu-central-1.amazonaws.com/deepset.ai-farm-qa/datasets/documents/table_text_dataset.zip" | |||
There was a problem hiding this comment.
@MichelBartels Once the dataset is uploaded, please replace the line in the dictionary here:
haystack/haystack/telemetry.py
Line 205 in 8cd73a9
| @@ -88,7 +88,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
…aystack into table_eval_tutorial
bogdankostic
suggested changes
Mar 29, 2022
There was a problem hiding this comment.
Thanks for working on this, looking already really good to me. Before merging, it would be nice to see the following points addressed:
- Please remove the KeyboardInterrupt output from the notebook
- It would be nice to have the outputs of the print methods in the notebook. Like this, the user doesn't need to run the notebook in order to understand what the outcome of the different sections is.
- The Evaluation section is missing in the
.py-file - Please add labels to the PR.
MichelBartels
added
topic:tableQA
type:documentation
|
Thanks @bogdankostic, I have made your suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
This adds an evaluation and a document conversion segment to tutorial 15. For this, it was necessary to change the dataset to a dataset with labels.