Ci cd take2

[mikaelene]

Add the adapter tests

[mikaelene]

The new settings for connections breaks old way of setting up profile. Needs to be fixed before merge. Otherwise the tests are actually running quite good!

Thanks @swanderz

[dataders]

@mikaelene by "breaks old way of setting up profile" do you mean that I've toggled Encrypt to now be False by default instead of True?

[mikaelene]

Something like that. I removed the cert settings stuff from my profile and it stopped working. Just have to make sure the pr doesn’t break the adapter for all users 😀

[mikaelene]

@swanderz I managed to isolate the problem with standard connections to on-prem SQL Server. Looks like when adding Authentcation=SqlPassword to the connections string, some settings around encryption and certificate are changed to a value that doesn't work out of the box. By removing that setting it all works. The question is if it still works with Azure sql with user pass?

[dataders]

EUREKA! You're incredible @mikaelene for finding this. At first glace, I thought "there's no way that can be it", but you're totally right. Finally my lifelong dream to become an expert in Microsoft ODBC Connection String Keywords has been fulfilled. 😝 This docs page has some juicy snippets that I'll paste here for posterity.

Example Connection Strings

SQL Server Authentication - legacy syntax.
Server certificate is not validated, and encryption is used only if the server enforces it.
The username/password is passed in the connection string.
server=Server;database=Database;UID=UserName;PWD=Password;

SQL Authentication - new syntax.
The client requests encryption (the default value of Encrypt is true) and the server certificate gets validated, regardless of the encryption setting (unless TrustServerCertificate is set to true).
The username/password is passed in the connection string.
server=Server;database=Database;UID=UserName;PWD=Password;Authentication=SqlPassword;

also this farther down the page

Notes
To connect using a SQL Server account username and password, you may now use the new SqlPassword option, which is recommended especially for Azure SQL since this option enables more secure connection defaults.

[dataders]

@mikaelene everything's good on our end! whenever you're ready

[mikaelene]

This looks great! I imagine that snapshot-check did work before. Can it be that it do work but the test have some issues verifying it? Anyway, lets merge this this to master, do some test runs on actual dbt-projects and then publish to pip :-)