Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase CI test coverage for connection target types #65

Closed
8 tasks
dataders opened this issue Dec 7, 2020 · 5 comments
Closed
8 tasks

increase CI test coverage for connection target types #65

dataders opened this issue Dec 7, 2020 · 5 comments
Milestone

Comments

@dataders
Copy link
Collaborator

dataders commented Dec 7, 2020

give the weird behavior we saw with connection strings and SqlPassword=True. @NandanHegde15 had the idea to have a separate Circle CI job would be verify that dbt debug works on all target configurations that are commonly used. We can either add this to #62 or in a new PR after #62 is merged.

The ones I can think of:

  • trusted_connection=True
  • windows_integrated=True
  • when Encrypt and TrustServerCertificate aren't specified
  • the various combos ofEncrypt, TrustServerCertificate, and SqlPassword
  • Active Directory
    • Password
    • Integrated (trickier as it would require a VM and an AD user in the same RG as the Azure SQL server)
    • Interactive
@mikaelene
Copy link
Collaborator

That would be really great. It would really help improve stability on releases to be confident that this doesn't break. I think after #62 is merged. To make the merges smaller.

@dataders
Copy link
Collaborator Author

@jtcohen6 could you help us think how to best set up running dbt debug against all permutations of target configs? for example, we want to make sure that the connections.py logic works whether:

  • the values are true or false, and if
  • the params aren't specified.
encrypt: true
trust_cert: true

we'd also need to do the same with all the AAD auth methods...

@jtcohen6
Copy link
Contributor

@swanderz I don't think dbt debug returns nonzero exit codes, but you could do it just as well by executing a dbt compile command with each permutation.

I think you could do that outside of the pytest framework to start: create a sample.profiles.yml with a whole range of targets. In your Circle steps, copy that profile and execute dbt compile --target {target} for each.

@mikaelene
Copy link
Collaborator

Is anyone working on this? I would really like to push a new version to pypi. But then we need to make sure that all functionality we are shipping are working as expected...

@dataders
Copy link
Collaborator Author

dataders commented Jan 4, 2021

working on this today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants