more sophisticated versioning (take 2) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Dec 17, 2020
|
I don't understand why the CI job fails? I have merged #62 to master and it runs well. |
So I botched the copy and paste. fixed now. |
dataders
commented
Dec 17, 2020
| @@ -0,0 +1 @@ | |||
| version = '0.18.0b2' | |||
There was a problem hiding this comment.
@mikaelene @jtcohen6 any guidance on what this version should be? We'll prolly cut a release soon-ish that incorporates all of these recent PRs....
do we include the most recent patch release (.1) number? what does the b mean?
Suggested change
| version = '0.18.0b2' | |
| version = '0.18.1b0' |
There was a problem hiding this comment.
I have not done any 0.18.1 release yet. If we fix the snapshot-check-strategy and make sure all connections variations work. Why not 0.18.1? 😀. That is a dbt version that it works well with
mikaelene
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to resolve #66. should merge #62 first probably so we can get an auto-check that this PR doesn't break anything