Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/python model v1 #182

Merged
merged 34 commits into from
Jul 28, 2022
Merged

Feature/python model v1 #182

merged 34 commits into from
Jul 28, 2022

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Jun 29, 2022 •
edited
Loading

This change currently includes table materialization and incremental materialization.

Also super happy to hear any feedback and what you think we missed.

TODOs:

ChenyuLInx and others added 18 commits June 1, 2022 18:30
@ChenyuLInx
push snowflake implementation refactored from drews code
872bbad
@ChenyuLInx
add py_materialize_as_table
1797501
@ChenyuLInx
add load df def
68c66f7
@jtcohen6 @ChenyuLInx
Bump version to 1.3.0a1
8a6b066
@ChenyuLInx
make session global so we can load table with dbt ref
49bb604
@ChenyuLInx
update requirement for the moment and fix format
1490de2
@ChenyuLInx
remove logging and add functional test
d61a212
@jtcohen6
Misc experimentation
86e6f11
@ChenyuLInx
make snowflake work
1cc2158
@ChenyuLInx
fix indentation
bc0b241
@ChenyuLInx
update materialization macro
2f4c113 
make snowflake work
@ChenyuLInx
resolve pandas df save and update entry function name
2bfddc6
@ChenyuLInx
update python model tests
7d2c51b
@ChenyuLInx
adjust for compiled_code syntax
61a9ff3
@ChenyuLInx
Merge pull request #3 from dbt-labs/python-model
4219827
@ChenyuLInx
refactor submit python and attampt for incremental
037ff06
@ChenyuLInx
adjust name
4b88f3f
@ChenyuLInx @jtcohen6
refactor submit and misc expirements
85e34f5 
Co-authored-by: jtcohen6 <[email protected]>
@cla-bot cla-bot bot added the cla:yes label Jun 29, 2022
ChenyuLInx
ChenyuLInx commented Jun 29, 2022
View reviewed changes
tests/functional/adapter/test_python_model.py
models__simple_python_model_v2 = """
import pandas

def model(dbt, session):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the model code looks like, we are enforcing session here because it is local to the function and certain operations depends on it

@jtcohen6 jtcohen6 mentioned this pull request Jul 5, 2022
Closed
1 task
@ChenyuLInx
Copy link
Contributor Author

@jtcohen6 this is ready minus the part copy grants won't work for python model, it need some refactor that probably should be ticketed work. Created #214 to track it

@ChenyuLInx ChenyuLInx marked this pull request as ready for review July 26, 2022 01:06
gshank
gshank approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Remember to remove branch from dev-requirements.txt before merging.

ChenyuLInx
ChenyuLInx commented Jul 27, 2022
View reviewed changes
dev-requirements.txt Outdated Show resolved Hide resolved
@ChenyuLInx ChenyuLInx merged commit c0b9274 into main Jul 28, 2022
@ChenyuLInx ChenyuLInx deleted the feature/python-model-v1 branch July 28, 2022 19:42
@tglunde tglunde mentioned this pull request Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42

@stu-k stu-k Awaiting requested review from stu-k

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChenyuLInx @gshank @jtcohen6