You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are configurations that are applied within the create table as statement in Snowflake: transient cluster_by copy_grants + automatic_clustering
Right now in python models we are just saving everything with default settings. We should reach parity for this for python models where possible and raise a clear error when running with options that is not supported. This probably involves having py_write_table take in those parameters and generate the correct python code
Motivation:
User would be able to optimize the storage format based on their usage of the table.
Acceptance criteria
Python model would materialize the table with the correct option, and raise error when unsupported option is being specified.
Tests for the PR
You should add integration tests to run the table materialization with supported options, then check that the table has intended property, for example this might be a way to check partitions. You should also add tests to to make sure we raised the error on unsupported options.
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
Refactor copy grants so it would work for python model
[CT-935] Refactor copy grants so it would work for python model
Jul 26, 2022
jtcohen6
changed the title
[CT-935] Refactor copy grants so it would work for python model
[CT-935] Adapter-specific configs not supported by Python models
Jul 26, 2022
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.
Describe the feature
These are configurations that are applied within the
create table as
statement in Snowflake:transient
cluster_by
copy_grants + automatic_clustering
Right now in python models we are just saving everything with default settings. We should reach parity for this for python models where possible and raise a clear error when running with options that is not supported. This probably involves having
py_write_table
take in those parameters and generate the correct python codeMotivation:
User would be able to optimize the storage format based on their usage of the table.
Acceptance criteria
Python model would materialize the table with the correct option, and raise error when unsupported option is being specified.
Tests for the PR
You should add integration tests to run the table materialization with supported options, then check that the table has intended property, for example this might be a way to check partitions. You should also add tests to to make sure we raised the error on unsupported options.
The text was updated successfully, but these errors were encountered: