Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-935] Adapter-specific configs not supported by Python models #214

Closed
ChenyuLInx opened this issue Jul 26, 2022 · 3 comments
Closed

[CT-935] Adapter-specific configs not supported by Python models #214

ChenyuLInx opened this issue Jul 26, 2022 · 3 comments
Labels

Comments

@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Jul 26, 2022

Describe the feature

These are configurations that are applied within the create table as statement in Snowflake:
transient
cluster_by
copy_grants + automatic_clustering

Right now in python models we are just saving everything with default settings. We should reach parity for this for python models where possible and raise a clear error when running with options that is not supported. This probably involves having py_write_table take in those parameters and generate the correct python code

Motivation:

User would be able to optimize the storage format based on their usage of the table.

Acceptance criteria

Python model would materialize the table with the correct option, and raise error when unsupported option is being specified.

Tests for the PR

You should add integration tests to run the table materialization with supported options, then check that the table has intended property, for example this might be a way to check partitions. You should also add tests to to make sure we raised the error on unsupported options.

@ChenyuLInx ChenyuLInx added enhancement New feature or request triage labels Jul 26, 2022
@github-actions github-actions bot changed the title Refactor copy grants so it would work for python model [CT-935] Refactor copy grants so it would work for python model Jul 26, 2022
@ChenyuLInx ChenyuLInx mentioned this issue Jul 26, 2022
3 tasks
@jtcohen6 jtcohen6 changed the title [CT-935] Refactor copy grants so it would work for python model [CT-935] Adapter-specific configs not supported by Python models Jul 26, 2022
@jtcohen6
Copy link
Contributor

These are configurations that are applied within the create table as statement in Snowflake:

  • transient
  • cluster_by
  • copy_grants + automatic_clustering

@iknox-fa
Copy link
Contributor

iknox-fa commented Aug 1, 2022

Estimations in JIRA reflect assumption that all table options are available when creating tables in Snowpark.

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants