Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Carbon mapper #795

Closed
14 tasks done
rvsia opened this issue Sep 9, 2020 · 4 comments · Fixed by #817
Closed
14 tasks done

Introduce Carbon mapper #795

rvsia opened this issue Sep 9, 2020 · 4 comments · Fixed by #817
Assignees
Labels
Carbon PRs/Issues for IBM's Carbon design system enhancement New feature or request released

Comments

@rvsia
Copy link
Contributor

rvsia commented Sep 9, 2020

Scope: Carbon

Description

Introduce Carbon mapper to DDF repo

https://react.carbondesignsystem.com/?path=/story/button--default

TODO:

@rvsia rvsia added the enhancement New feature or request label Sep 9, 2020
@rvsia rvsia self-assigned this Sep 9, 2020
@rvsia rvsia added the Carbon PRs/Issues for IBM's Carbon design system label Sep 9, 2020
@rvsia
Copy link
Contributor Author

rvsia commented Sep 10, 2020

Changelog of changes PF3 > Carbon WORK IN PROGRESS

No isRequired

Carbon recommends to mark only optional fields (see here, so there is no isRequired prop.)

Required field

🛑

{
   component: 'text-field',
   label: 'login',
   isRequired: true,
}

🆗

{
   component: 'text-field',
   label: 'login',
}

Optional field

🛑

{
   component: 'text-field',
   label: 'description',
}

🆗

{
   component: 'text-field',
   label: 'description (optional)',
}

The Carbon documentation also suggests to group optional fields to avoid repeatable (optional) text.

Select

No isClearable

Carbon select does not support isClearable option, instead of it use an option with null.

🛑

{
   component: 'select',
   label: 'select',
   isClearable: true,
   options: [
        {value: 'option 1', label: 'first option'},
        {value: 'option 2', label: 'second option'}
    ]
}

🆗

{
   component: 'select',
   label: 'select',
   options: [
         {label: 'none', value: null},
         {value: 'option 1', label: 'first option'},
         {value: 'option 2', label: 'second option'}
    ]
}

Single select cannot be isSearchable

No known workaround.

No async filtering options in multiselect

No known workaround.

Possible workaround: reimplement Carbon select as we did for PF4/PF3

@rvsia
Copy link
Contributor Author

rvsia commented Sep 10, 2020

Slider bug addressed here carbon-design-system/carbon#6809

@rvsia
Copy link
Contributor Author

rvsia commented Sep 10, 2020

Toggle (Switch) labelText issues addresed here carbon-design-system/carbon#6811

@Hyperkid123
Copy link
Member

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Carbon PRs/Issues for IBM's Carbon design system enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants