Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add texts for Cabon components #808

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Add texts for Cabon components #808

merged 1 commit into from
Sep 17, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Sep 16, 2020 •
edited
Loading

Part of #795

@rvsia rvsia added the Carbon PRs/Issues for IBM's Carbon design system label Sep 16, 2020
@rvsia rvsia mentioned this pull request Sep 16, 2020
Closed
14 tasks
@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #808 into carbon will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           carbon     #808   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         231      231           
  Lines        3520     3520           
  Branches     1134     1134           
=======================================
  Hits         3275     3275           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9981b...e401c53. Read the comment docs.

@rvsia rvsia force-pushed the addTextsForCarbonComponents branch from b819266 to e401c53 Compare September 17, 2020 10:57
@rvsia rvsia requested a review from Hyperkid123 September 17, 2020 10:58
@rvsia rvsia marked this pull request as ready for review September 17, 2020 10:58
@Hyperkid123 Hyperkid123 merged commit 7d68642 into data-driven-forms:carbon Sep 17, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.9.0 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the addTextsForCarbonComponents branch October 7, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@Hyperkid123 Hyperkid123

Labels
Carbon PRs/Issues for IBM's Carbon design system released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvsia @Hyperkid123