Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carbon): fix spacing for form template #813

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Sep 23, 2020

@rvsia rvsia added the Carbon PRs/Issues for IBM's Carbon design system label Sep 23, 2020
@rvsia rvsia requested a review from Hyperkid123 September 23, 2020 12:22
@rvsia rvsia mentioned this pull request Sep 23, 2020
14 tasks
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #813 into carbon will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           carbon     #813      +/-   ##
==========================================
+ Coverage   92.34%   93.10%   +0.75%     
==========================================
  Files         231      231              
  Lines        3473     3522      +49     
  Branches     1116     1134      +18     
==========================================
+ Hits         3207     3279      +72     
+ Misses        266      243      -23     
Impacted Files Coverage Δ
...bon-component-mapper/src/files/dual-list-select.js 100.00% <100.00%> (+70.00%) ⬆️
...s/carbon-component-mapper/src/files/field-array.js 100.00% <100.00%> (+75.00%) ⬆️
...carbon-component-mapper/src/files/form-template.js 100.00% <100.00%> (ø)
...ckages/carbon-component-mapper/src/files/wizard.js 100.00% <100.00%> (+71.42%) ⬆️
packages/common/src/form-template.js 100.00% <100.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d68642...0be757a. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit ecc8af3 into data-driven-forms:carbon Sep 23, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.9.0 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the properFormStyling branch October 7, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Carbon PRs/Issues for IBM's Carbon design system released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants