Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate non-deterministic IS support #5553

Merged
merged 9 commits into from
Nov 20, 2023
Merged

refactor: deprecate non-deterministic IS support #5553

merged 9 commits into from
Nov 20, 2023

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Aug 30, 2023 •
edited
Loading

Issue being fixed or feature implemented

Non-deterministic IS locks aren't used anymore since v18 dip24.
We should drop that support to make code simpler.

What was done?

Dropped non-deterministic IS code, evo_instantsend_tests and feature_llmq_is_migration.py (don't need it anymore), adjusted func tests.

How Has This Been Tested?

all tests, synced Testnet

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides added this to the 20 milestone Aug 30, 2023
@ogabrielides ogabrielides marked this pull request as draft August 31, 2023 10:49
@ogabrielides ogabrielides changed the title chore: drop feature_is_migration refactor: deprecate non-deterministic IS support Oct 10, 2023
@ogabrielides ogabrielides force-pushed the drop_is_migration_test branch from 999d46a to 068dcbd Compare October 10, 2023 16:00
@github-actions
Copy link

This pull request has conflicts, please rebase.

@ogabrielides ogabrielides force-pushed the drop_is_migration_test branch from 068dcbd to d2b1bec Compare October 29, 2023 09:47
UdjinM6
UdjinM6 requested changes Oct 30, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see d9b67c2

note: it's rebased on top of #5654 and #5655. I reindexed on testnet and mainnet with no issues. It's still incomplete though, check FIXME.

@ogabrielides ogabrielides force-pushed the drop_is_migration_test branch from d2b1bec to bb9a118 Compare October 30, 2023 22:52
@ogabrielides
Copy link
Collaborator Author

ogabrielides commented Oct 31, 2023 •
edited
Loading

@UdjinM6 Since #4917 connections are ensured among IS quorums: adjusted feature_llmq_connections.py to this logic since with this PR, only llmq_test_dip0024 provide IS functionality in regtest.
Also, borrowed fix from #5657.

@ogabrielides ogabrielides marked this pull request as ready for review October 31, 2023 12:23
@ogabrielides ogabrielides requested a review from UdjinM6 October 31, 2023 12:23
@ogabrielides ogabrielides modified the milestones: 20, 20.1 Nov 1, 2023
@ogabrielides ogabrielides force-pushed the drop_is_migration_test branch from 7fe4720 to 6943813 Compare November 1, 2023 11:19
@ogabrielides ogabrielides requested a review from UdjinM6 November 1, 2023 11:21
UdjinM6
UdjinM6 previously approved these changes Nov 1, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to be working correctly (client-side) on mainnet/testnet

light ACK

knst
knst reviewed Nov 9, 2023
View reviewed changes
src/llmq/instantsend.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please rebase.

@ogabrielides ogabrielides force-pushed the drop_is_migration_test branch from 5fb40e7 to 864b679 Compare November 10, 2023 15:59
@ogabrielides ogabrielides requested review from knst and UdjinM6 November 10, 2023 16:04
UdjinM6
UdjinM6 previously approved these changes Nov 10, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase looks clean, utACK

src/llmq/instantsend.cpp Outdated Show resolved Hide resolved
@UdjinM6
Copy link

UdjinM6 commented Nov 16, 2023

rebased via GH GUI to fix merge ff check

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please rebase.

@ogabrielides ogabrielides dismissed stale reviews from UdjinM6 and knst via e638575 November 17, 2023 16:57
@ogabrielides ogabrielides force-pushed the drop_is_migration_test branch from 9f2e584 to e638575 Compare November 17, 2023 16:57
@ogabrielides ogabrielides requested review from knst and UdjinM6 November 17, 2023 17:08
UdjinM6
UdjinM6 approved these changes Nov 17, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

knst
knst approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@thephez thephez added the P2P Some notable changes on p2p level label Nov 20, 2023
PastaPastaPasta
PastaPastaPasta approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 1125649 into dashpay:develop Nov 20, 2023
5 of 11 checks passed
@ogabrielides ogabrielides deleted the drop_is_migration_test branch November 20, 2023 16:21
@PastaPastaPasta
Copy link
Member

This PR resulted in a breaking change via the removal of option llmqtestinstantsend

thephez added a commit to thephez/docs-core that referenced this pull request Feb 19, 2024
@thephez
docs(p2p): move islock to deprecated message type table
6c55116 
Related to dashpay/dash#5553
thephez added a commit to dashpay/docs-core that referenced this pull request Feb 19, 2024
@thephez
docs(p2p): islock deprecation (#100)
c205841 
* docs(p2p): move islock to deprecated message type table

Related to dashpay/dash#5553

* docs: minor table formatting
@UdjinM6 UdjinM6 mentioned this pull request Feb 29, 2024
Merged
5 tasks
@thephez thephez mentioned this pull request Mar 4, 2024
Merged
thephez added a commit to thephez/docs-core that referenced this pull request Mar 5, 2024
@thephez
docs(p2p): islock deprecation (dashpay#100)
4d47c5f 
* docs(p2p): move islock to deprecated message type table

Related to dashpay/dash#5553

* docs: minor table formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst knst approved these changes

Assignees
No one assigned
Labels
P2P Some notable changes on p2p level
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ogabrielides @UdjinM6 @PastaPastaPasta @knst @thephez