Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust LLMQ_TEST_DIP0024 params, mine_cycle_quorum should use correct size #5655

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: adjust LLMQ_TEST_DIP0024 params, mine_cycle_quorum should use correct size #5655

merged 2 commits into from
Oct 30, 2023

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Oct 29, 2023

Issue being fixed or feature implemented

Small dip0024 related cleanups, regtest only.

What was done?

pls see individual commits

How Has This Been Tested?

run tests

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Oct 29, 2023
@UdjinM6 UdjinM6 mentioned this pull request Oct 30, 2023
Merged
5 tasks
ogabrielides
ogabrielides approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

PastaPastaPasta
PastaPastaPasta reviewed Oct 30, 2023
View reviewed changes
src/llmq/params.h
@@ -202,7 +202,7 @@ static constexpr std::array<LLMQParams, 14> available_llmqs = {
.useRotation = true,
.size = 4,
.minSize = 4,
.threshold = 2,
Copy link
Member

@PastaPastaPasta PastaPastaPasta Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change on devnet that should be documented (at least in PR description) no? Honestly would probably prefer "release-notes" file even though this probably wouldn't make it into final release notes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a regtest-only quorum

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LLMQ type is used only on regtest. The one for devnet is: LLMQ_DEVNET_DIP0024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

PastaPastaPasta
PastaPastaPasta approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit fa19c5f into dashpay:develop Oct 30, 2023
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielides ogabrielides ogabrielides approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @ogabrielides @PastaPastaPasta