Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release notes for 20.1.0 #5910

Merged
1 commit merged into from
Mar 4, 2024

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Added release notes for 20.1.0

What was done?

Wrote release notes from WIP release-notes; trimmed some fat from release notes

How Has This Been Tested?

Ran linters

Breaking Changes

None; docs only

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 20.1 milestone Feb 28, 2024
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Show resolved Hide resolved
- `fundrawtransaction` and `walletcreatefundedpsbt` when used with the `lockUnspents` argument now lock manually
selected coins, in addition to automatically selected coins. Note that locked coins are never used in automatic coin
selection, but can still be manually selected.
- The `testmempoolaccept` RPC returns `vsize` and a `fee` object with the `base` fee if the transaction passes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename vsize to size due to no SegWit? if it will be renamed now before release - no breaking changes. Rename it later - it would be a breaking changes.

doc/release-notes.md Show resolved Hide resolved
support and will be removed in future releases. Importantly, even with an HD wallet, users can still import non-HD
private keys, ensuring flexibility in managing their funds.

## Configuration option changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Configuration option changes
## Windows release
Windows release is signed by a new certificate to replace old expired one.

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
knst
knst previously approved these changes Feb 29, 2024
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UdjinM6
Copy link

UdjinM6 commented Feb 29, 2024

I think we should also mention complete removal of legacy IS support (no -llmqinstantsend and -llmqtestinstantsend cmd-line options, no islock msg, no inv 30) #5553 and protocol bump to 70231 #5905

doc/release-notes.md Outdated Show resolved Hide resolved
@PastaPastaPasta
Copy link
Member Author

I think we should also mention complete removal of legacy IS support (no -llmqinstantsend and -llmqtestinstantsend cmd-line options, no islock msg, no inv 30) #5553 and protocol bump to 70231 #5905

Would you like to propose some language around this?

@UdjinM6
Copy link

UdjinM6 commented Mar 1, 2024

I think we should also mention complete removal of legacy IS support (no -llmqinstantsend and -llmqtestinstantsend cmd-line options, no islock msg, no inv 30) #5553 and protocol bump to 70231 #5905

Would you like to propose some language around this?

I think smth like:

Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure smooth transition. v20.1 finally removes all of Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. To make it clear that there was a change in network protocol the version was bumped to 70231. Please note that -llmqinstantsend and -llmqtestinstantsend command line options are no longer available either.

I'd like to also ask @thephez to rephrase it to sound a bit better though :)

@thephez
Copy link
Collaborator

thephez commented Mar 2, 2024

Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure smooth transition. v20.1 finally removes all of Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. To make it clear that there was a change in network protocol the version was bumped to 70231. Please note that -llmqinstantsend and -llmqtestinstantsend command line options are no longer available either.

Looks good. I just made a couple small changes...

Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure a smooth transition. v20.1 finally removes all Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. The protocol version was incremented to 70231 to indicate a change in network protocol. Please note that the -llmqinstantsend and -llmqtestinstantsend command line options have also been removed as part of this change.

@PastaPastaPasta PastaPastaPasta requested review from knst and thephez March 3, 2024 16:37
knst
knst previously approved these changes Mar 3, 2024
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UdjinM6
UdjinM6 previously approved these changes Mar 4, 2024
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deterministic IS section is at the wrong heading level. Also, fixed a couple typos in that section.

doc/release-notes.md Outdated Show resolved Hide resolved
@PastaPastaPasta PastaPastaPasta requested a review from knst March 4, 2024 14:54
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Co-authored-by: thephez <[email protected]>
Co-authored-by: Konstantin Akimov <[email protected]>
Co-authored-by: UdjinM6 <[email protected]>
@PastaPastaPasta PastaPastaPasta closed this pull request by merging all changes into dashpay:develop in 032c8fa Mar 4, 2024
PastaPastaPasta added a commit that referenced this pull request Apr 3, 2024
7f57516 docs: add v20.0.4 release notes (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  We didn't archive v20.0.4 release notes somehow in #5910

  ## What was done?
  Archive 20.0.4 release notes

  ## How Has This Been Tested?

  ## Breaking Changes
  None

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: d703dedf1aad2afb5eb8af291f89e38fa2dfb4185ef9e25194c273bb9f04ae8075ea87318552b468b1a487b39b95cf1dee794d3d3c5b8a863dbfd6d458ee8e72
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Apr 3, 2024
7f57516 docs: add v20.0.4 release notes (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  We didn't archive v20.0.4 release notes somehow in dashpay#5910

  ## What was done?
  Archive 20.0.4 release notes

  ## How Has This Been Tested?

  ## Breaking Changes
  None

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: d703dedf1aad2afb5eb8af291f89e38fa2dfb4185ef9e25194c273bb9f04ae8075ea87318552b468b1a487b39b95cf1dee794d3d3c5b8a863dbfd6d458ee8e72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants