-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add release notes for 20.1.0 #5910
Conversation
doc/release-notes.md
Outdated
- `fundrawtransaction` and `walletcreatefundedpsbt` when used with the `lockUnspents` argument now lock manually | ||
selected coins, in addition to automatically selected coins. Note that locked coins are never used in automatic coin | ||
selection, but can still be manually selected. | ||
- The `testmempoolaccept` RPC returns `vsize` and a `fee` object with the `base` fee if the transaction passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename vsize
to size
due to no SegWit? if it will be renamed now before release - no breaking changes. Rename it later - it would be a breaking changes.
doc/release-notes.md
Outdated
support and will be removed in future releases. Importantly, even with an HD wallet, users can still import non-HD | ||
private keys, ensuring flexibility in managing their funds. | ||
|
||
## Configuration option changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Configuration option changes | |
## Windows release | |
Windows release is signed by a new certificate to replace old expired one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think smth like:
I'd like to also ask @thephez to rephrase it to sound a bit better though :) |
Looks good. I just made a couple small changes... Legacy InstantSend was deprecated with the activation of Deterministic InstantSend but we kept the underlying logic for some time to ensure a smooth transition. v20.1 finally removes all Legacy InstantSend logic and will no longer support sending and receiving islock p2p message and inv p2p message with id equal 30. Such messages will be seen as unknown by v20.1 nodes. The protocol version was incremented to 70231 to indicate a change in network protocol. Please note that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deterministic IS section is at the wrong heading level. Also, fixed a couple typos in that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
2ddfce5
to
717257c
Compare
Co-authored-by: thephez <[email protected]> Co-authored-by: Konstantin Akimov <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
717257c
to
a4edab6
Compare
032c8fa
7f57516 docs: add v20.0.4 release notes (pasta) Pull request description: ## Issue being fixed or feature implemented We didn't archive v20.0.4 release notes somehow in #5910 ## What was done? Archive 20.0.4 release notes ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: d703dedf1aad2afb5eb8af291f89e38fa2dfb4185ef9e25194c273bb9f04ae8075ea87318552b468b1a487b39b95cf1dee794d3d3c5b8a863dbfd6d458ee8e72
7f57516 docs: add v20.0.4 release notes (pasta) Pull request description: ## Issue being fixed or feature implemented We didn't archive v20.0.4 release notes somehow in dashpay#5910 ## What was done? Archive 20.0.4 release notes ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: d703dedf1aad2afb5eb8af291f89e38fa2dfb4185ef9e25194c273bb9f04ae8075ea87318552b468b1a487b39b95cf1dee794d3d3c5b8a863dbfd6d458ee8e72
Issue being fixed or feature implemented
Added release notes for 20.1.0
What was done?
Wrote release notes from WIP release-notes; trimmed some fat from release notes
How Has This Been Tested?
Ran linters
Breaking Changes
None; docs only
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.