-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate knora-api-js-lib #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a9482b.
flavens
approved these changes
Dec 12, 2019
kilchenmann
added a commit
that referenced
this pull request
Dec 20, 2019
* Integrate knora-api-js-lib (#215) * chore: First steps to use knora-api-js-lib and new core module * chore(landing page): Update knora app title * Revert "chore(landing page): Update knora app title" This reverts commit 8a9482b. * refactor(main): Update app title * chore(main): New method to get projecs * fix(help): Get knora version with new config * chore(project): New method to get projec * chore(project): New method to get project * refactor(project): Clean up * feat(header): Login / logout * refactor: Clean up @knora/api imports * chore(user): Update user status * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * chore: Update config * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * refactor: Response instead of result * refactor: Clean up imports * test: Refactor test settings * test: Refactor test settings * chore: Using latest knora-ui/core module * chore: Using latest knora-ui/core module * chore: Project form * refactor: Delete unused session validation * test: Update travis config * test: Update travis config * test: Update travis config * test: Try to fix test * style(user): No margin in tab * fix: Make service method angular conform * chore: Set title with "Knora App" * fix: Update project (hack) * fix: Update project (hack) * fix: Session validation * refactor(user): Remove console.log * refactor: Remove @knora/authentication * chore(admin): Try to create or edit user and project * fix(user): Create / update user * fix: Using @knora/api wip/100-optional-properties * fix: Project form to edit / create projects * fix: Project form to edit / create projects * test: Update travis and circleci config * test: Fix some tests * refactor: Clean up code * style: Fix header style issue on mobile device * chore(workspace): Show res toolbar * docs: Update README and config * test: Improve tests * style(search): Style fix for FF * feat: Project admin is able to add existing users * fix: Disable project admin to create system admin * chore: Fix new @knora/core implementation * fix: Bug fix in user profile * feat: Show sysAdmin info on user profile * test: Fix tests * feat: Show own project admin status in list of projects * fix: Bug fix after deactivate own account * chore: Update footer * test: Fix broken tests * fix: Fix typo error * Integrate admin lists (#222) * fix(list): Get labels value * feat(list): Replace ListsService and class definitions by the corresponding ones from the lib * fix(list): Fix response type * chore: Update travis + circle-ci for tests * chore: Reverse the previous modifications in travis + circle-ci for tests * chore(list): Remove console.log * fix: Update list info * refactor: Remove console.logs * Improvements on landing and help page (#226) * fix: Resolves #148 * chore: Update landing page and footer * test: Update CI config * refactor: Removed console.logs * fix: Fix broken links * Pre-release v2.0.0 (#227) * chore: Update @knora module packages * test: Update CI config * docs: Update knora-api version * fix: Bug fix project cache in edit and create mode * test: Fix travis ci config Co-authored-by: Flavie L. <[email protected]>
kilchenmann
added a commit
that referenced
this pull request
Jan 10, 2020
* Integrate knora-api-js-lib (#215) * chore: First steps to use knora-api-js-lib and new core module * chore(landing page): Update knora app title * Revert "chore(landing page): Update knora app title" This reverts commit 8a9482b. * refactor(main): Update app title * chore(main): New method to get projecs * fix(help): Get knora version with new config * chore(project): New method to get projec * chore(project): New method to get project * refactor(project): Clean up * feat(header): Login / logout * refactor: Clean up @knora/api imports * chore(user): Update user status * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * chore: Update config * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * refactor: Response instead of result * refactor: Clean up imports * test: Refactor test settings * test: Refactor test settings * chore: Using latest knora-ui/core module * chore: Using latest knora-ui/core module * chore: Project form * refactor: Delete unused session validation * test: Update travis config * test: Update travis config * test: Update travis config * test: Try to fix test * style(user): No margin in tab * fix: Make service method angular conform * chore: Set title with "Knora App" * fix: Update project (hack) * fix: Update project (hack) * fix: Session validation * refactor(user): Remove console.log * refactor: Remove @knora/authentication * chore(admin): Try to create or edit user and project * fix(user): Create / update user * fix: Using @knora/api wip/100-optional-properties * fix: Project form to edit / create projects * fix: Project form to edit / create projects * test: Update travis and circleci config * test: Fix some tests * refactor: Clean up code * style: Fix header style issue on mobile device * chore(workspace): Show res toolbar * docs: Update README and config * test: Improve tests * style(search): Style fix for FF * feat: Project admin is able to add existing users * fix: Disable project admin to create system admin * chore: Fix new @knora/core implementation * fix: Bug fix in user profile * feat: Show sysAdmin info on user profile * test: Fix tests * feat: Show own project admin status in list of projects * fix: Bug fix after deactivate own account * chore: Update footer * test: Fix broken tests * fix: Fix typo error * fix(project admin): Update project admin information * chore: Fixing cache issues * Integrate admin lists (#222) * fix(list): Get labels value * feat(list): Replace ListsService and class definitions by the corresponding ones from the lib * fix(list): Fix response type * chore: Update travis + circle-ci for tests * chore: Reverse the previous modifications in travis + circle-ci for tests * chore(list): Remove console.log * fix: Update list info * refactor: Remove console.logs * test: Fix bugs in CI config * refactor: Remove console.log * refactor: Remove console.log * refactor: Remove comments and fix project admin setup * fix: Bug fix with projectAdmin Co-authored-by: Flavie L. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the new knora-api-js-lib and fixes some bugs and issues.