Fix issues on cache service #221
Conversation
* chore: First steps to use knora-api-js-lib and new core module * chore(landing page): Update knora app title * Revert "chore(landing page): Update knora app title" This reverts commit 8a9482b. * refactor(main): Update app title * chore(main): New method to get projecs * fix(help): Get knora version with new config * chore(project): New method to get projec * chore(project): New method to get project * refactor(project): Clean up * feat(header): Login / logout * refactor: Clean up @knora/api imports * chore(user): Update user status * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * chore: Update config * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * chore: More on knora-api-js-lib integration * refactor: Response instead of result * refactor: Clean up imports * test: Refactor test settings * test: Refactor test settings * chore: Using latest knora-ui/core module * chore: Using latest knora-ui/core module * chore: Project form * refactor: Delete unused session validation * test: Update travis config * test: Update travis config * test: Update travis config * test: Try to fix test * style(user): No margin in tab * fix: Make service method angular conform * chore: Set title with "Knora App" * fix: Update project (hack) * fix: Update project (hack) * fix: Session validation * refactor(user): Remove console.log * refactor: Remove @knora/authentication * chore(admin): Try to create or edit user and project * fix(user): Create / update user * fix: Using @knora/api wip/100-optional-properties * fix: Project form to edit / create projects * fix: Project form to edit / create projects * test: Update travis and circleci config * test: Fix some tests * refactor: Clean up code * style: Fix header style issue on mobile device * chore(workspace): Show res toolbar * docs: Update README and config * test: Improve tests * style(search): Style fix for FF * feat: Project admin is able to add existing users * fix: Disable project admin to create system admin * chore: Fix new @knora/core implementation * fix: Bug fix in user profile * feat: Show sysAdmin info on user profile * test: Fix tests * feat: Show own project admin status in list of projects * fix: Bug fix after deactivate own account * chore: Update footer * test: Fix broken tests * fix: Fix typo error
* fix(list): Get labels value * feat(list): Replace ListsService and class definitions by the corresponding ones from the lib * fix(list): Fix response type * chore: Update travis + circle-ci for tests * chore: Reverse the previous modifications in travis + circle-ci for tests * chore(list): Remove console.log * fix: Update list info * refactor: Remove console.logs
|
At the moment, we can't remove the cache service completely, because it's needed a lot in the admin part and it works not so bad. We should decide about the future of cache service later on. |
Cleaned-up
No specific reason. I'll remove them and ask you again for reviewing... |
There was a problem hiding this comment.
I found out one weird issue: I created a user and added it to BEOL (as ProjectAdmin) and a random local project of mine (user member only) but it is not a SystemAdmin.
I logged in again with this new account.
When I go on the project section, some features are not accessible, e.g. the Edit project button (project description page), the collaboration content (/collaboration - error 403 thrown), the lists content (/lists - error 403 thrown). However the project toolbar menu is well displayed (because of the ProjectAdmin permissions).
Chrome console on the project description page
Error 403
Local storage
|
@flavens I will fix it --> Done! |
This PR resolves #220, removes cache service and redirect functions