Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project admin should be able to add existing users to its project #100

Closed
flavens opened this issue Oct 9, 2019 · 8 comments
Closed

Project admin should be able to add existing users to its project #100

flavens opened this issue Oct 9, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@flavens
Copy link
Contributor

flavens commented Oct 9, 2019

Is your feature request related to a problem? Please describe.
Only system admins can add users to any projects. But the project admin should be allowed to do the same for their projects.

Describe the solution you'd like
A project admin can add existing users in its projects. System admin can keep the privilege to create a new user.

Describe alternatives you've considered
N.A.

Additional context
Spotted during the drafting of the test protocol document.

@flavens flavens added the enhancement New feature or request label Oct 9, 2019
@flavens flavens added this to the 2019-12 milestone Oct 9, 2019
@kilchenmann
Copy link
Contributor

This is an issue in knora-api. Only system admin is able to get a list of all users of the system.

@subotic
Copy link
Contributor

subotic commented Oct 24, 2019

So, you need the whole list, so that the ProjectAdmin can pick a user and add him to the project? I could add this.

@kilchenmann
Copy link
Contributor

@subotic That would be great.
Yes, similar to github, where you can add any existing user to a repository or to a team just by typing username or name.

@subotic
Copy link
Contributor

subotic commented Oct 25, 2019

It‘s merged. ProjectAdmin should now be able to get all users.

@kilchenmann
Copy link
Contributor

Thanks @subotic. We will implement it into to the app asap.

@kilchenmann kilchenmann modified the milestones: 2019-12, 2019-11 Oct 25, 2019
@kilchenmann kilchenmann modified the milestones: 2019-11, 2019-12 Nov 28, 2019
@kilchenmann
Copy link
Contributor

kilchenmann commented Dec 6, 2019

@subotic the implementation works but I figured out, that a project admin can create new user, which is good, but he can also set the new user as system admin, which shouldn't be possible. In the app I will disable the corresponding form element and I'll write an issue in knora-api (dasch-swiss/dsp-api#1552)

@flavens flavens modified the milestones: 2019-12, 2020-01 Dec 16, 2019
@flavens
Copy link
Contributor Author

flavens commented Jan 20, 2020

@kilchenmann what is the status of this issue? Still in progress due to (dasch-swiss/dsp-api#1552) ?

@kilchenmann
Copy link
Contributor

I think we can close this issue. dasch-swiss/dsp-api#1552 has another topic and is part of the api. I solved the mentioned issue already in the app by disable system-admin toggle in user form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants