-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CombiningBuilder for .g.dart files and document how to use it #319
Comments
Supported return values include a single `String` or multiple Strings within an `Iterable` or `Stream`. It is also valid to return a `Future` of any of the above. Duplicate values are also collapsed across Generators within a Builder. This allows creating shared helpers. Progress towards #319
@grouma – added some work items before we can close this. The first two are handled by my pending PR |
How are we doing w/ the check boxes here @natebosch and @grouma ? |
...still need to tweak build.yaml, right? |
I think it looks correct (other than a nit about single vs double quotes). README and example are the remaining issues. I wanted also to validate usage which is what google/json_serializable.dart#260 is meant to accomplish. |
ack
…On Thu, Jul 19, 2018 at 9:45 AM Nate Bosch ***@***.***> wrote:
...still need to tweak build.yaml, right?
I think it looks correct (other than a nit about single vs double quotes).
README and example are the remaining issues. I wanted also to validate
usage which is what google/json_serializable.dart#260
<google/json_serializable.dart#260> is meant to
accomplish.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCir3Xw-YG0rAS8prOWR_tmhzHz74_ks5uILfAgaJpZM4Sy-EV>
.
|
Towards #319 These never need to be served or included in the merged output directory so they should always be cleaned by the post process builder.
Towards #319 These never need to be served or included in the merged output directory so they should always be cleaned by the post process builder.
Towards #319 Describes how to use SharedPartBuilder to write to .g.dart files, including how to configure the `build.yaml`. Remove references to Transformers.
Towards #319 Describes how to use SharedPartBuilder to write to .g.dart files, including how to configure the `build.yaml`. Remove references to Transformers.
@natebosch – I think we're don here, right? For the example, I want to add it after this package is published so it can refer to published packages and be easier to copy-paste |
yes, I think we are safe to publish now. @grouma, @jakemac53 - can you think of anything else blocking? |
I haven't been following this to closely 😬 but nothing blocking I am aware of. |
Version bumb to v1 first?
…On Mon, Jul 23, 2018, 12:49 Jacob MacDonald ***@***.***> wrote:
I haven't been following this to closely 😬 but nothing blocking I am
aware of.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCiqfZ5UAyyn_gS3JWcQkbVi7ujQh1ks5uJii1gaJpZM4Sy-EV>
.
|
Should be good to go. |
There's an example now, I think we've finished. |
Towards dart-lang/source_gen#319 These never need to be served or included in the merged output directory so they should always be cleaned by the post process builder.
Towards dart-lang/source_gen#319 Describes how to use SharedPartBuilder to write to .g.dart files, including how to configure the `build.yaml`. Remove references to Transformers.
Towards dart-lang/source_gen#319 These never need to be served or included in the merged output directory so they should always be cleaned by the post process builder.
Towards dart-lang/source_gen#319 Describes how to use SharedPartBuilder to write to .g.dart files, including how to configure the `build.yaml`. Remove references to Transformers.
We added
runs_before
andapplies_builder
to build config so it should be possible now to put everything together with one or more source_gen part builders cooperating to generate a single part file. We'll want a "CombiningBuilder" ("MergingBuilder"?) in this package to read in all the files generated by different part builders and write them to a single output.part
directive - Fixes for CombiningBuilder #348build.yaml
to properly exposeCombiningBuilder
After published...
repo/example
The text was updated successfully, but these errors were encountered: