Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CombiningBuilder for .g.dart files and document how to use it #319

Closed
7 tasks done
natebosch opened this issue Mar 21, 2018 · 11 comments
Closed
7 tasks done

Add a CombiningBuilder for .g.dart files and document how to use it #319

natebosch opened this issue Mar 21, 2018 · 11 comments
Assignees
Labels
status-blocked Blocked from making progress by another (referenced) issue

Comments

@natebosch
Copy link
Member

natebosch commented Mar 21, 2018

We added runs_before and applies_builder to build config so it should be possible now to put everything together with one or more source_gen part builders cooperating to generate a single part file. We'll want a "CombiningBuilder" ("MergingBuilder"?) in this package to read in all the files generated by different part builders and write them to a single output.

After published...

  • Add a working example to repo/example
kevmoo added a commit that referenced this issue Jun 12, 2018
Supported return values include a single `String` or multiple Strings
within an `Iterable` or `Stream`. It is also valid to return a `Future`
of any of the above.

Duplicate values are also collapsed across Generators within a Builder.
This allows creating shared helpers.

Progress towards #319
@kevmoo
Copy link
Member

kevmoo commented Jun 18, 2018

@grouma – added some work items before we can close this. The first two are handled by my pending PR

@kevmoo
Copy link
Member

kevmoo commented Jul 19, 2018

How are we doing w/ the check boxes here @natebosch and @grouma ?

@kevmoo
Copy link
Member

kevmoo commented Jul 19, 2018

...still need to tweak build.yaml, right?

@natebosch
Copy link
Member Author

...still need to tweak build.yaml, right?

I think it looks correct (other than a nit about single vs double quotes). README and example are the remaining issues. I wanted also to validate usage which is what google/json_serializable.dart#260 is meant to accomplish.

@kevmoo
Copy link
Member

kevmoo commented Jul 19, 2018 via email

natebosch added a commit that referenced this issue Jul 19, 2018
Towards #319

These never need to be served or included in the merged output directory
so they should always be cleaned by the post process builder.
natebosch added a commit that referenced this issue Jul 19, 2018
Towards #319

These never need to be served or included in the merged output directory
so they should always be cleaned by the post process builder.
natebosch added a commit that referenced this issue Jul 19, 2018
Towards #319

Describes how to use SharedPartBuilder to write to .g.dart files,
including how to configure the `build.yaml`.

Remove references to Transformers.
natebosch added a commit that referenced this issue Jul 19, 2018
Towards #319

Describes how to use SharedPartBuilder to write to .g.dart files,
including how to configure the `build.yaml`.

Remove references to Transformers.
@kevmoo
Copy link
Member

kevmoo commented Jul 23, 2018

@natebosch – I think we're don here, right?

For the example, I want to add it after this package is published so it can refer to published packages and be easier to copy-paste

@natebosch
Copy link
Member Author

yes, I think we are safe to publish now. @grouma, @jakemac53 - can you think of anything else blocking?

@jakemac53
Copy link
Contributor

I haven't been following this to closely 😬 but nothing blocking I am aware of.

@kevmoo
Copy link
Member

kevmoo commented Jul 23, 2018 via email

@grouma
Copy link
Member

grouma commented Jul 24, 2018

Should be good to go.

@natebosch
Copy link
Member Author

There's an example now, I think we've finished.

mosuem pushed a commit to dart-lang/build that referenced this issue Dec 10, 2024
Towards dart-lang/source_gen#319

These never need to be served or included in the merged output directory
so they should always be cleaned by the post process builder.
mosuem pushed a commit to dart-lang/build that referenced this issue Dec 10, 2024
Towards dart-lang/source_gen#319

Describes how to use SharedPartBuilder to write to .g.dart files,
including how to configure the `build.yaml`.

Remove references to Transformers.
mosuem pushed a commit to dart-lang/build that referenced this issue Dec 10, 2024
Towards dart-lang/source_gen#319

These never need to be served or included in the merged output directory
so they should always be cleaned by the post process builder.
mosuem pushed a commit to dart-lang/build that referenced this issue Dec 10, 2024
Towards dart-lang/source_gen#319

Describes how to use SharedPartBuilder to write to .g.dart files,
including how to configure the `build.yaml`.

Remove references to Transformers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-blocked Blocked from making progress by another (referenced) issue
Projects
None yet
Development

No branches or pull requests

4 participants