Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a new build_runner is available #56

Closed
zoechi opened this issue Feb 9, 2018 · 14 comments
Closed

a new build_runner is available #56

zoechi opened this issue Feb 9, 2018 · 14 comments

Comments

@zoechi
Copy link
Contributor

zoechi commented Feb 9, 2018

but not yet supported by built_redux

@zoechi
Copy link
Contributor Author

zoechi commented Feb 9, 2018

and a new build

@davidmarne
Copy link
Contributor

Updating would be tricky before google/built_value.dart#342 is merged, as built_redux has a dev_dependency on built_value_generator. I'm gonna wait until that gets merged to proceed with built_redux.

Also, the environment restrictions imposed by the new version of build_runner is a concern to me.
sdk: '>=2.0.0-dev.20 <2.0.0'

Given the fact that there is no confirmed release date for dart 2, I might move forward with a pre-release, rather than a normal release. Thoughts?

@zoechi
Copy link
Contributor Author

zoechi commented Feb 12, 2018

Looks like the built_value PR is close to being merged.

I think moving forward with a pre-release is fine.

@zoechi
Copy link
Contributor Author

zoechi commented Feb 14, 2018

The new built_value should be available

@davidmarne
Copy link
Contributor

So i took a look at this. I created a build.yaml, however when I try to generate files I get:

DuplicateAssetNodeError: GeneratedAssetNode: built_redux|lib/builder.g.dart generated from input built_redux|lib/builder.dart.
This probably means you have multiple actions that are trying to output the same file

Which makes sense, since both are using source_gen's PartBuilder.

I can get it working if I generate with a different extension than '.g.dart', however that is obviously not ideal.

@davidmarne
Copy link
Contributor

That might have to be the solution, I really don't see a way around it.

@zoechi
Copy link
Contributor Author

zoechi commented Feb 15, 2018

You could ask the developers of the build package. I didn't have a chance yet to have a closer look at the new ways

@davidmarne
Copy link
Contributor

create dart-lang/build#1030

@davidmarne
Copy link
Contributor

looks like there is already an issue here: dart-lang/build#975

@btastic
Copy link
Contributor

btastic commented Feb 26, 2018

So there is no way to use your library right now? I was excited to try this after reading on Brian Egans repository. But all I get is errors.

Running the generator script is giving me

'package:mime/src/mime_multipart_transformer.dart': malformed type: line 33 pos 13: cannot resolve class 'StreamTransformerBase' from 'MimeMultipartTransformer'
    extends StreamTransformerBase<List<int>, MimeMultipart> {

@davidmarne
Copy link
Contributor

@btastic just in case you didn't see, I did comment on your flutter_built_redux issue with a couple potential workarounds to that error, which should get you going using build_runner 0.6.x

However, it still looks like there are some issues being worked out over at github.com/dart-lang/build that I would like to see get resolved before committing to supporting build_runner 0.7.x in built_redux

@zoechi
Copy link
Contributor Author

zoechi commented Mar 14, 2018

Is this still blocked?

@davidmarne
Copy link
Contributor

@zoechi sorry to leave u hanging :(

It won't be perfect until dart-lang/source_gen#319 is resolved, but there aren't any blockers for pushing out a dev branch. I just published a dev tag, 7.4.0-dev, to pub. You can see the branch and instructions for configuring build_runner to work with built_value and built_redux here:

https://github.com/davidmarne/built_redux/tree/7.4.0-dev

@zoechi
Copy link
Contributor Author

zoechi commented Mar 29, 2018

@davidmarne no worries
Thanks a lot for your great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants